Skip to content

ci: set 30 minutes timeout to the integration test step #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crazy-max wants to merge 1 commit into from
Closed

ci: set 30 minutes timeout to the integration test step #1086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ jobs:
-
name: Test
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
timeout-minutes: 30
Copy link
Copy Markdown

@tcely tcely Apr 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timeout-minutes: 30
timeout-minutes: 35

Because the test is already using 30 minutes with test.each, it might be worth lowering the timeout inside the test.

actions-toolkit/__tests__/docker/install.test.itg.ts

Lines 40 to 54 in 3c03d19

describe('root', () => {
// prettier-ignore
test.each(getSources(true))(
'install docker %s', async (source) => {
await ensureNoSystemContainerd();
const install = new Install({
source: source,
runDir: tmpDir(),
contextName: 'foo',
daemonConfig: `{"debug":true,"features":{"containerd-snapshotter":true}}`
});
await expect(tryInstall(install)).resolves.not.toThrow();
}, 30 * 60 * 1000);
}); 

const TEST_TIMEOUT = (1000 * 60) * 25; // minutes

Copy link
Copy Markdown

@tcely tcely Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have asked an AI agent to analyze my proposed change to the timeout values:

By setting the internal test timeout to 25 minutes, you've built in a 10-minute buffer that is critical for two reasons:

  1. The Teardown Window: If a Docker install hangs on macOS, the finally block in your code calls install.tearDown(). Without that 10-minute buffer, the GitHub runner would likely kill the process while it’s still trying to clean up, resulting in lost logs or orphaned resources.
  2. Step Overhead: The GitHub "Test" step isn't just the code execution; it’s also the vitest initialization and the beforeAll hooks. Your 35-minute limit covers that "invisible" time that the 25-minute test timer ignores.

This setup ensures that if things go wrong, the test fails gracefully (with an error message) rather than the runner failing abruptly (with a generic cancellation).

Copy link
Copy Markdown
Member Author

@crazy-max crazy-max Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will normalize vitest timeouts in relation to runner one

with:
script: |
const testName = `${{ matrix.test_name }}`;
Expand Down
Loading