handle healthcheck.disable true in isServiceHealthy #13494
+144
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Func
ToMobyHealthCheckconverts disabled helthchecks to[]string{"NONE"}.Made changes in isServiceHealthy, to also consider the above as "no healthecheck", as it will never be
nilAdditionally added some unit tests. To be honest, the tests ONLY were generated by AI.
Related downstream issue: getarcaneapp/arcane#1338
I used the following code to test. Before my changes it would fail, after my changes, not.