Skip to content

Nicer message #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgageot merged 1 commit into from
Apr 8, 2026
+6 −2
Merged

Nicer message #2345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/runtime/fallback.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,13 +324,17 @@ func (r *LocalRuntime) tryModelWithFallback(
// If the last error (or any error in the chain) was a context overflow,
// wrap it in a ContextOverflowError so the caller can auto-compact.
if lastErr != nil {
wrapped := fmt.Errorf("all models failed: %w", lastErr)
prefix := "model failed"
if hasFallbacks {
prefix = "all models failed"
}
wrapped := fmt.Errorf("%s: %w", prefix, lastErr)
if modelerrors.IsContextOverflowError(lastErr) {
return streamResult{}, nil, modelerrors.NewContextOverflowError(wrapped)
}
return streamResult{}, nil, wrapped
}
return streamResult{}, nil, errors.New("all models failed with unknown error")
return streamResult{}, nil, errors.New("model failed with unknown error")
}

// retryDecision is the outcome of handleModelError.
Expand Down
Loading