fix: style error and icon#629
Conversation
There was a problem hiding this comment.
Pull request overview
This PR cleans up dark theme styling for the GUI after the Vue 3 / antd v4 migration (#599). Instead of overriding antd component styles manually in SCSS, it leans on antd's built-in theme.darkAlgorithm via <a-config-provider :theme="themeConfig">, keeps only a few app-specific dark overrides (sider, labels, big-button, pre-release banner/tag), and fixes the experiment icon in the FreeEye plugin page by switching to the v4 ExperimentOutlined component.
Changes:
- Configure antd v4 dark/light algorithm and tokens via
a-config-providerinApp.vue, and remove the:themeprop ona-layout-siderin favor of an inline background style. - Strip most antd component overrides from
dark.scss, replace the sider background rule, add.big-buttonand.pre-release-*dark variants, and remove the unused$dark-inputvariable. - Replace the legacy
icon="experiment"string prop on the FreeEye run button with the imported<ExperimentOutlined/>component.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| packages/gui/src/view/App.vue | Adds themeConfig computed wired to antd v4 algorithm/tokens; replaces sider :theme with inline background style. |
| packages/gui/src/view/style/theme/dark.scss | Removes many antd-specific dark overrides; adds sider/label/big-button/pre-release dark rules. |
| packages/gui/src/view/style/index.scss | Adds a trailing newline only. |
| packages/gui/src/view/pages/plugin/free-eye.vue | Uses ExperimentOutlined icon component instead of the deprecated icon="experiment" string prop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <div class="ds_layout" :class="themeClass"> | ||
| <a-layout> | ||
| <a-layout-sider :theme="theme" style="overflow-y: auto"> | ||
| <a-layout-sider :style="{ background: theme === 'dark' ? '#1e1f22' : '#fff', overflowY: 'auto' }"> |
|
完成了？ 字体变成ubuntu mono了？边栏的鼠标悬浮特效挺好看的 |
|
根据 copilot 的 review 包括Heavy use of !important等，统一使用 |
这都啥 另外虽然ip address invalid的问题没修就合并是我当时脑子不大清楚，但反正现在修好了 最后，大规模重构必须更加谨慎。动辄成百上千行代码变更很容易翻车 copilot的问题也不是每个都得管，但是我指出的都要弄好。搞完叫我 |
好像不会吧，这个应该是 #631 的 |
|
@cute-omega master的CI |
Ⅰ. 描述此PR的作用：
修复在 #599 的一些样式，统一使用antd 4 进行dark实现，和fix一个icon
Ⅱ. 此PR修复了哪个issue吗？
None
Ⅲ. 界面变化截屏