Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends input field definitions in Protocol Buffer messages by adding additional PDF-specific configuration fields. The changes enable more granular control over PDF form field behavior and appearance, including accessibility features, input constraints, and formatting options.
Key Changes:
- Added 12 new boolean fields to
ProtoInputFieldTextfor PDF-specific flags (readonly, required, multiline, password, etc.) - Added 2 new string fields to
ProtoInputFieldText:altandpdf_input_height - Added 3 new fields to
ProtoInputFieldCheckbox:pdf_printing_behavior,pdf_form_name, andalt - Version bump from 0.7.2 to 0.7.3
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/DocumentElements/documentelements.input_field.proto | Source proto definitions with new fields for text and checkbox input types |
| build/docframe.proto | Compiled proto with new field additions |
| docframepb/docframe.pb.go | Generated Go code with new field accessors and updated protoc version |
| build/Docframe.js | Generated JavaScript code with new property definitions and serialization logic |
| build/Docframe.cs | Generated C# code with new properties and serialization methods |
| package.json | Version increment to 0.7.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c144779 to
45c6242
Compare
| ProtoBaseInputField base = 2; | ||
| repeated string comChannelUUIDs = 3; | ||
| string uuid = 4; | ||
| PDFPrintingBehavior pdfPrintingBehavior = 5; |
There was a problem hiding this comment.
We should create a new type "ProtoBasePDFSettings" or similar because those properties are already present at the input field text. If necessary we can create a new major version.
45c6242 to
cfe042d
Compare
lukasbash
left a comment
There was a problem hiding this comment.
As mentioned, please unify common properties in some pdf base proto.
No description provided.