Remove unused select() method from PowerRanker#115
Merged
kronosapiens merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
The select() method has been superseded by activeSelect(), which uses a more sophisticated multi-signal approach (coverage, proximity, position) instead of simple variance weighting. Remove dead code: select(), getVariances(), getVariance(), SelectOptions, ImpactTransform. Update README to document the actual bidirectional encoding and activeSelect() API. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the deprecated
select()method and its supporting code (getVariances(),getVariance(),SelectOptions,ImpactTransform), which has been fully replaced byactiveSelect().The
activeSelect()method uses a more sophisticated multi-signal approach (coverage, proximity, position) with regularization, providing better pair selection for judging sessions.Also corrects README documentation to accurately describe the bidirectional encoding scheme and the
activeSelect()API.All 112 backend tests pass.