Skip to content

TCoasterKiller 92%#75

Merged
Mrkol merged 1 commit intodoldecomp:mainfrom
Cuyler36:coasterkiller
Feb 4, 2026
Merged

TCoasterKiller 92%#75
Mrkol merged 1 commit intodoldecomp:mainfrom
Cuyler36:coasterkiller

Conversation

@Cuyler36
Copy link
Contributor

@Cuyler36 Cuyler36 commented Feb 3, 2026

Gets coaster to ~92%. Most of the remaining work needs to be done in JGeometry::TQuat4's methods. I referenced what was in the SMG1 repo to scaffold the functions to use.

Also includes some work on TBathtubKiller and TRocket that were necessary or helpful.

@decomp-dev
Copy link

decomp-dev bot commented Feb 3, 2026

Report for GMSJ01 (3962fcf - d1873f7)

📈 Matched code: 25.84% (+0.13%, +4836 bytes)
📈 Matched data: 27.77% (+0.28%, +1820 bytes)

✅ 34 new matches
Unit Item Bytes Before After
mario/Enemy/coasterkiller .data +1080 0.00% 100.00%
mario/Enemy/coasterkiller __sinit_coasterkiller_cpp +764 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterKiller::isCollidMove(THitActor*) +556 0.00% 100.00%
mario/Enemy/coasterkiller .rodata +512 0.00% 100.00%
mario/Enemy/coasterkiller TNerveCoasterKillerExplosion::execute(TSpineBase<TLiveActor>*) const +384 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterKiller::setMActorAndKeeper() +340 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterKiller::init(TLiveManager*) +320 0.00% 100.00%
mario/Enemy/coasterkiller TNerveCoasterEnemyWander::execute(TSpineBase<TLiveActor>*) const +312 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterKiller::attackToMario() +308 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterKiller::behaveToWater(THitActor*) +280 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterEnemy::init(TLiveManager*) +232 0.00% 100.00%
mario/Enemy/coasterkiller .bss +208 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterEnemy::~TCoasterEnemy() +156 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterKiller::~TCoasterKiller() +156 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterEnemy::calcRootMatrix() +144 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterKillerManager::~TCoasterKillerManager() +116 0.00% 100.00%
mario/Enemy/coasterkiller TNerveCoasterKillerExplosion::~TNerveCoasterKillerExplosion() +92 0.00% 100.00%
mario/Enemy/coasterkiller TNerveCoasterEnemyWander::~TNerveCoasterEnemyWander() +92 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterKiller::setNormalFlyAnm() +84 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterKiller::reset() +80 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterEnemy::reset() +80 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterKillerManager::TCoasterKillerManager(const char*) +68 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterEnemy::makeCoasterGoalPath() +60 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterKillerManager::createModelData() +52 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterEnemy::setWalkAnm() +44 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterEnemy::perform(unsigned long, JDrama::TGraphics*) +44 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterEnemy::moveObject() +32 0.00% 100.00%
mario/Enemy/coasterkiller .sbss +16 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterKiller::getBasNameTable() const +12 0.00% 100.00%
mario/Enemy/coasterkiller TCoasterEnemy::getGravityY() const +8 0.00% 100.00%

...and 4 more new matches

📈 13 improvements in unmatched items
Unit Item Bytes Before After
mario/Enemy/coasterkiller TCoasterEnemy::moveCoaster() +329 0.00% 19.23%
mario/Enemy/BathtubKiller TBathtubKiller::makeQuat(JGeometry::TVec3<float>, float, float) +276 0.00% 18.07%
mario/Enemy/coasterkiller TCoasterEnemy::bind() +192 0.00% 87.27%
mario/Enemy/coasterkiller TCoasterKiller::perform(unsigned long, JDrama::TGraphics*) +188 0.00% 52.48%
mario/Enemy/coasterkiller TCoasterKillerManager::createEnemyInstance() +147 0.00% 97.37%
mario/Enemy/coasterkiller TCoasterKiller::setDeadAnm() +132 0.00% 73.33%
mario/Player/ModelWaterManager TWaterEmitInfo::TWaterEmitInfo(const char*) +120 66.80% 78.80%
mario/Enemy/coasterkiller TCoasterKiller::TCoasterKiller(const char*) +91 0.00% 95.83%
mario/Enemy/coasterkiller TCoasterKillerManager::load(JSUMemoryInputStream&) +88 0.00% 30.26%
mario/Enemy/coasterkiller .sdata2 +58 0.00% 90.91%
mario/Enemy/BathtubKiller .sdata2 +32 0.00% 27.03%
mario/Enemy/coasterkiller TCoasterKillerManager::loadAfter() +32 0.00% 61.54%
mario/Enemy/coasterkiller .sdata +4 0.00% 50.00%
📉 1 regression in an unmatched item
Unit Item Bytes Before After
mario/GC2D/ConsoleStr TConsoleStr::processGo(float) -7 2.38% 1.90%

@Mrkol Mrkol merged commit f7daa84 into doldecomp:main Feb 4, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants