Skip to content

Conversation

@Howriq
Copy link
Member

@Howriq Howriq commented Nov 25, 2025

No description provided.

Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
@Howriq
Copy link
Member Author

Howriq commented Nov 25, 2025

This is the functional code for chapter 2. I want to call it "Migrations and Entities".

Maybe I can remove a couple of files, for example TimestampsTrait.php. The tutorial might get overcrowded otherwise.
I could also add it as a good practice 😉

@arhimede
Copy link
Member

what about all those failed actions ?

@Howriq
Copy link
Member Author

Howriq commented Nov 25, 2025

what about all those failed actions ?

They are mainly from:

  • doctrine migration line being too long,
  • type docs which we said would cover in a different tutorial
  • the main README which is very chaotic

@arhimede
Copy link
Member

what about all those failed actions ?

They are mainly from:

* doctrine migration line being too long,

* type docs which we said would cover in a different tutorial

* the main README which is very chaotic

It is not relevant the cause
I am expecting to be fixed and see green all over the place

Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this supposed to stay on its own branch?
Because I see that you try to merge chapter-2 into chapter-1 - or you did this only so that we can see the differences between the two branches, without the intention to merge them.

Signed-off-by: Howriq <horea@rospace.com>
@Howriq Howriq requested a review from alexmerlin November 26, 2025 20:33
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
@Howriq
Copy link
Member Author

Howriq commented Nov 27, 2025

I presume that you found that this file is required even without the upload avatar feature I mentioned.
That's why you did not delete it?
Please confirm.

That file was no longer required. I have removed it.

@Howriq Howriq requested a review from alexmerlin November 27, 2025 08:05
Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more items and it's good to go...

Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
@alexmerlin alexmerlin marked this pull request as draft November 27, 2025 10:20
Howriq and others added 2 commits December 9, 2025 20:07
Signed-off-by: Howriq <horea@rospace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants