-
Notifications
You must be signed in to change notification settings - Fork 1
Chapter 2 code #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: chapter-1
Are you sure you want to change the base?
Chapter 2 code #12
Conversation
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
|
This is the functional code for chapter 2. I want to call it "Migrations and Entities". Maybe I can remove a couple of files, for example |
|
what about all those failed actions ? |
They are mainly from:
|
It is not relevant the cause |
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
alexmerlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this supposed to stay on its own branch?
Because I see that you try to merge chapter-2 into chapter-1 - or you did this only so that we can see the differences between the two branches, without the intention to merge them.
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
That file was no longer required. I have removed it. |
alexmerlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more items and it's good to go...
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
remove local.php
No description provided.