-
-
Notifications
You must be signed in to change notification settings - Fork 1k
[build] Add windows-11-arm and ubuntu-24.04-arm to CI run-tests.yaml #2760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
@timcassell tried to address issues in the two tests. As I have no insight into the specifics of these I am somewhat guessing here, so it is probably more a more efficient use of time if you guys just fix these directly yourselves, so feel free to make changes here or elsewhere necessary for these CI changes. Or let me know what to do specifically. :) |
|
I don't have a Windows Arm machine to test with, so I can only go off of the logs. |
|
|
|
If you have an Arm machine to test with, can you try to figure out why |
|
It seems Is this settings ares used inside integration tests? |
I don't have any ARM pc. Hence, why I am in no better shape to fix these issues, worse even since have no idea why these tests look like they do. 😅 So if anybody has an idea how to fix please do, or make a pr to this pr with necessary changes. |
|
I pushed some test fixes, but I'm not sure how to fix remaining. Disassembler fails on New Mono tests are all failing @adamsitnik Maybe you have ideas, or could ping someone who might? |
This comment was marked as resolved.
This comment was marked as resolved.
7134a1f to
e210245
Compare
I am sorry, I've missed this GH notification (I am signed up to everything in BDN and sometimes I struggle to find direct mentions). It's very likely that Mono does not support it by design. Let's exclude the problematic tests for given configs. |
Ignore NoHangs test on full Framework on non-x86.
df32788 to
0e7034c
Compare
timcassell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The report job is running forever and can't be canceled (unrelated).
Thanks @nietras.
|
Wonderful, @timcassell thanks for finishing it. |
cc @timcassell