Skip to content

[7.0] Fix 3714 | Extract SqlBulkCopy column names using dynamic SQL#4057

Closed
edwardneal wants to merge 2 commits intodotnet:release/7.0from
edwardneal:fix/3714-sqlbulkcopy-sql2016
Closed

[7.0] Fix 3714 | Extract SqlBulkCopy column names using dynamic SQL#4057
edwardneal wants to merge 2 commits intodotnet:release/7.0from
edwardneal:fix/3714-sqlbulkcopy-sql2016

Conversation

@edwardneal
Copy link
Copy Markdown
Contributor

Description

Backports #3719 to 7.0

Issues

Backports #3719. Original issue is #3714. Fixes #4056.

Testing

As per original PR.

This enables the query to compile correctly when the graph_type column is missing
@edwardneal edwardneal requested a review from a team as a code owner March 17, 2026 21:20
@github-project-automation github-project-automation bot moved this to To triage in SqlClient Board Mar 17, 2026
@mdaigle mdaigle added this to the 7.0.1 milestone Mar 17, 2026
@priyankatiwari08 priyankatiwari08 moved this from To triage to In review in SqlClient Board Mar 24, 2026
@paulmedynski paulmedynski changed the title Bugfix | Backport 3719 to 7.0 Fix 3714 | Extract SqlBulkCopy column names using dynamic SQL Mar 25, 2026
@paulmedynski paulmedynski changed the title Fix 3714 | Extract SqlBulkCopy column names using dynamic SQL [7.0] Fix 3714 | Extract SqlBulkCopy column names using dynamic SQL Mar 25, 2026
@paulmedynski paulmedynski linked an issue Mar 25, 2026 that may be closed by this pull request
@paulmedynski
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/7.0@9bce6ad). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...Client/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             release/7.0    #4057   +/-   ##
==============================================
  Coverage               ?   65.61%           
==============================================
  Files                  ?      275           
  Lines                  ?    65828           
  Branches               ?        0           
==============================================
  Hits                   ?    43193           
  Misses                 ?    22635           
  Partials               ?        0           
Flag Coverage Δ
PR-SqlClient-Project 65.61% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski
Copy link
Copy Markdown
Contributor

We will re-visit this as a Copilot-created PR once #3719 merges.

@github-project-automation github-project-automation bot moved this from In review to Done in SqlClient Board Mar 26, 2026
@edwardneal edwardneal deleted the fix/3714-sqlbulkcopy-sql2016 branch March 26, 2026 17:19
@paulmedynski paulmedynski removed this from the 7.0.1 milestone Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants