remove redundant StopWatch.Stop in SendBroadcastUDPRequest#4102
Open
SimonCropp wants to merge 1 commit intodotnet:mainfrom
Open
remove redundant StopWatch.Stop in SendBroadcastUDPRequest#4102SimonCropp wants to merge 1 commit intodotnet:mainfrom
SimonCropp wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a redundant Stopwatch.Stop() call in SendBroadcastUDPRequest within the Managed SNI SSRP (SQL Server Browser) UDP broadcast discovery path, aiming to reduce unnecessary overhead.
Changes:
- Replace
new Stopwatch(); sw.Start();withStopwatch.StartNew(). - Remove the
try/finallyblock that only existed to callsw.Stop().
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ManagedSni/SsrpClient.netcore.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ManagedSni/SsrpClient.netcore.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a StopWatch.Elapsed is not use after the StopWatch.Stop, then the stop is redundant perf impact