[7.0] Added CI test stages for SQL Server 16 and 17.#4115
Draft
paulmedynski wants to merge 1 commit intocherry-pick/7.0/4033from
Draft
[7.0] Added CI test stages for SQL Server 16 and 17.#4115paulmedynski wants to merge 1 commit intocherry-pick/7.0/4033from
paulmedynski wants to merge 1 commit intocherry-pick/7.0/4033from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the repo’s CI infrastructure to add integration-test stages for legacy SQL Server versions (2016/2017) in CI runs (but not PR validation), while also incorporating prerequisite build/versioning updates (notably migrating test execution/build steps toward build2.proj and centralizing MDS versioning into MdsVersions.props).
Changes:
- Add CI-only test configurations for SQL Server 2016 and 2017 via a new
runLegacySqlTestspipeline parameter (default enabled for CI, disabled for PR). - Update pipeline test/build steps to invoke
build2.projtest targets and updated MSBuild properties. - Introduce
src/Microsoft.Data.SqlClient/MdsVersions.propsand align project/nuspec output paths + XML doc include paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/targets/GenerateThisAssemblyCs.targets | Defaults AssemblyFileVersion to AssemblyVersion when unset. |
| tools/specs/Microsoft.Data.SqlClient.nuspec | Updates package file layout to match new artifacts/output path conventions. |
| tools/props/Versions.props | Removes MDS versioning from this shared file; points to MdsVersions.props. |
| tools/intellisense/TrimDocs.ps1 | Makes doc trimming fail-fast ($ErrorActionPreference='Stop', throws on missing input). |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlTypes/SqlVector.cs | Fixes XML doc <include> relative paths. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlTypes/SqlJson.cs | Fixes XML doc <include> relative paths + minor formatting. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlDbTypeExtensions.cs | Fixes XML doc <include> relative paths. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDataReader.cs | Fixes XML doc <include> relative paths + whitespace-only diffs. |
| src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj | Enables doc generation, imports MdsVersions.props, updates OutputPath. |
| src/Microsoft.Data.SqlClient/ref/Microsoft.Data.SqlClient.csproj | Enables doc generation, imports MdsVersions.props, updates OutputPath, adjusts TrimDocs target. |
| src/Microsoft.Data.SqlClient/ref/Microsoft.Data.SqlClient.cs | Adjusts XML doc <include> paths in ref surface file. |
| src/Microsoft.Data.SqlClient/notsupported/Microsoft.Data.SqlClient.csproj | Imports MdsVersions.props, updates OutputPath and ref artifact path. |
| src/Microsoft.Data.SqlClient/MdsVersions.props | Adds centralized MDS assembly/package version derivation logic. |
| src/Microsoft.Data.SqlClient.sln | Updates solution items (pipeline/onebranch entries, adds MdsVersions.props). |
| eng/pipelines/sqlclient-pr-project-ref-pipeline.yml | Adds build2.proj path trigger; disables legacy SQL tests for PR. |
| eng/pipelines/sqlclient-pr-package-ref-pipeline.yml | Adds build2.proj path trigger; disables legacy SQL tests for PR. |
| eng/pipelines/dotnet-sqlclient-ci-core.yml | Adds runLegacySqlTests param and SQL 2016/2017 Windows test configurations. |
| eng/pipelines/common/templates/steps/run-all-tests-step.yml | Switches test execution from build.proj to build2.proj targets/props. |
| eng/pipelines/common/templates/steps/ci-project-build-step.yml | Updates driver build to build2.proj (but now Windows-only). |
| build2.proj | Adds/extends build/test/pack infrastructure; introduces PackMds and new args. |
Contributor
Author
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #4087 to release/7.0
Depends on #4110
Original PR Description
Description
We have been missing integration test coverage against SQL Server 16 and 17. This PR adds test stages for those versions, but only for CI runs.
Testing
Manual CI runs will confirm the stages are running correctly. They may fail though - since we're pretty sure we have some regressions (see #3714 for example).