Skip to content

Fix LoginWithFailover missing parser state check #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulmedynski wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

Fix LoginWithFailover missing parser state check #4140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Connection/SqlConnectionInternal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3662,7 +3662,15 @@ private void LoginWithFailover(
continue;
}

if (IsDoNotRetryConnectError(sqlex) || timeout.IsExpired)
// If state != closed, indicates that the parser encountered an error while
// processing the login response (e.g. an explicit error token). Transient
// network errors that impact connectivity will result in parser state being
// closed. Only network-level errors should trigger failover alternation;
// login-phase errors (like transient errors) should be thrown so they can
Comment on lines +3665 to +3669
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar/clarity: the new comment reads "If state != closed, indicates...". Consider rephrasing to "If state != Closed, it indicates..." (and optionally reference TdsParserState.Closed explicitly) to match the code and improve readability.

Copilot uses AI. Check for mistakes.
// be handled by the outer ConnectRetryCount loop.
if (_parser?.State is not TdsParserState.Closed ||
IsDoNotRetryConnectError(sqlex) ||
timeout.IsExpired)
{
// No more time to try again.
// Caller will call LoginFailure()
Expand Down
Loading