PR Pipeline - Part 1 by benrr101 · Pull Request #4308 · dotnet/SqlClient

benrr101 · 2026-05-26T22:17:07Z

Description

As the goal of this sprint, we want to create a new PR pipeline that simplifies all the complexities of the old one, reduces the test coverage to tests that can run simply and quickly, and completes quickly. This PR introduces the basics of that with a few more changes to come.

Test execution is gated by a build/pack stage - if PR doesn't build/pack successfully, test run fails fast. ~3min
Test matrix is split into the following platforms as stages in parallel:
- [Windows/Linux]
- [net462/net8.0/net9.0/net10.0]
Test projects that run as jobs within each stage in parallel:
- Abstractions ~2min
- Azure ~2min
- SqlClient Funtional ~3min
- SqlClient Manual - Local ~35min
- SqlClient Unit ~6min

This puts the total run time at ~40min in its current state. Compared to the current pipeline which has full runtimes of anywhere from 1.5hrs to 3hrs, this is a massive improvement.

Noteworthy notes have been added inline.

Remaining work

SqlClient Manual tests against Azure SQL
Code coverage collection and publishing
Operationalize the pipeline via triggers

Testing

Test run on internal ADO - https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=154092&view=results
Test run on public ADO -
Due diligence run of sqlclient-nonofficial - https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=154095&view=results

edwardneal · 2026-05-27T05:59:18Z

Is there any chance we could also fix both the PR and the main pipeline to respect the [PlatformSpecific(TestPlatforms.Windows)] pipeline? This is currently in use in DistributedTransactionTestWindows but the test criteria don't exclude it based on the CI leg's OS platform.

[PlatformSpecific] is defined in dotnet/arcade here, and its discoverer sets the category criteria here.

benrr101 · 2026-05-28T18:16:29Z

@edwardneal - you mean the PlatformSpecific attributes aren't being respected?

# Conflicts: # eng/pipelines/common/steps/restore-dotnet-tools.yml

Leaving the unused build step for now just in case we need it later

…bles to OneBranch variables file

Move a couple things around WIP for manual test configuration generation

…s it helps.

…TestExecuteReaderAsyncWithLargeQuery

…s_SqlAuth as flay

Moving the SA password retrieval deeper into the manual test job

benrr101 · 2026-05-26T22:18:19Z

@@ -4,11 +4,9 @@
 # See the LICENSE file in the project root for more information.                #


These variables were always meant to be common to all pipelines.

benrr101 · 2026-05-26T22:18:36Z

  - name: BUILD_OUTPUT
    value: $(REPO_ROOT)/artifacts
-
-  # Directory where downloaded pipeline artifacts (NuGet packages from earlier


These were moved to the onebranch-variables file

benrr101 · 2026-05-28T17:52:38Z

+#################################################################################
+# Licensed to the .NET Foundation under one or more agreements.                 #
+# The .NET Foundation licenses this file to you under the MIT license.          #
+# See the LICENSE file in the project root for more information.                #
+#################################################################################
+
+name: $(DayOfYear)$(Rev:rr)
+
+variables:
+  - template: /eng/pipelines/common/variables/common-variables.yml@self
+  - template: /eng/pipelines/pr/variables/pr-variables.yml@self
+


Yes, this will be covered in another PR to operationalize the pipeline.

benrr101 · 2026-05-28T18:07:18Z

+        pool:
+          vmImage: 'ubuntu-latest'
+


This isn't actually a problem - the pack target will fail if the windows binaries aren't built, and I can confirm that the job is passing as well as the output contains a full build.

benrr101 · 2026-05-28T18:09:01Z

+    "WorkloadIdentityFederationServiceConnectionId": "",
+    "KerberosDomainPassword": "",
+    "KerberosDomainuser": "",
+    "IsManagedInstance": false


This is fixed in #4297, but I'll also address it here.

benrr101 · 2026-05-28T18:42:04Z

            int numberOfRows = 10;

-            // Insert a bunch of rows in to the table.	
+            // Insert a bunch of rows in to the table.


All the following changes were auto "trim whitespace on save" behavior...

benrr101 · 2026-05-28T18:43:23Z

                IsSqlVectorSupported &&
                CheckVectorFloat16Supported();

+        public static bool IsDebugBuild


This enables us to skip tests if build configuration is DEBUG (or not). This is helpful because skipping will show that the test was skipped in test results, while #if DEBUG will omit it from complication and pretend the test never existed.

benrr101 · 2026-05-28T18:46:27Z

        public static void ConnectToSQLWithInstanceNameTest()
        {
            SqlConnectionStringBuilder builder = new(DataTestUtility.TCPConnectionString);
+            DataTestUtility.ParseDataSource(builder.DataSource, out string hostname, out _, out _);


This change was to address an issue where the tcp connection string parsing was brittle and couldn't handle hostnames with instance names or ports properly.

benrr101 · 2026-05-28T18:47:12Z

    {
        // Misc constants
-        private const int CALLBACK_TIMEOUT = 5000; // milliseconds
+        private const int CALLBACK_TIMEOUT = 20000; // milliseconds


This was an initial attempt to improve this test on linux, but it didn't make a difference. Test has just been marked flaky.

benrr101 · 2026-05-28T18:47:36Z

        public string TCPConnectionStringHGSVBS = null;
        public string TCPConnectionStringNoneVBS = null;
        public string TCPConnectionStringAASSGX = null;
+        public bool EnclaveEnabled = false;


These changes are also being made in #4297

edwardneal · 2026-05-28T19:39:46Z

That's correct @benrr101 - [PlatformSpecific] adds a category trait indicating that a test/test class is non-Linux/-OSX/-FreeBSD/-NetBSD, but the pipelines don't filter those traits away. This means that we end up with runs such as this one, where the Ubuntu and MacOS tests report a non-terminating failure because a test class marked with [PlatformSpecific(TestPlatforms.Windows)] continues to be run and throws an exception during execution with the message "This platform does not support distributed transactions."

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

benrr101 · 2026-05-29T00:32:40Z

This one has gotten too big and messy with copilot spam after a small change. Recreating the PR.

Copilot AI review requested due to automatic review settings May 26, 2026 22:17

github-project-automation Bot added this to SqlClient Board May 26, 2026

github-project-automation Bot moved this to To triage in SqlClient Board May 26, 2026

benrr101 added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label May 26, 2026

Copilot started reviewing on behalf of benrr101 May 26, 2026 22:17 View session

benrr101 added this to the 7.1.0-preview2 milestone May 26, 2026

This comment was marked as outdated.

Sign in to view

Copilot AI review requested due to automatic review settings May 27, 2026 18:03

Copilot started reviewing on behalf of benrr101 May 27, 2026 18:03 View session

This comment was marked as outdated.

Sign in to view

benrr101 added 18 commits May 28, 2026 13:23

Move install-dotnet to common/steps, first bits of pipeline

542fe64

# Conflicts: # eng/pipelines/common/steps/restore-dotnet-tools.yml

Adding build and pack steps and writing up the build/pack stage.

d96840b

Leaving the unused build step for now just in case we need it later

Move common variables to common folder. Move OneBranch specific varia…

50c02c8

…bles to OneBranch variables file

Rename prci-pipeline to pr-pipeline

2ee5492

First round of tests

cca94d8

Run build/pack regardless of previous package.

d57e1f4

Run tree and publish artifact regardless of previous success

9ed3852

Completely untested, let's see what it does.

60782cf

Rename build-and-pack-stage.yml

3c85479

tree on linux

578ba0f

Fix test framework

adfabcf

Switch images to ones that have sql server on it

dc8d733

Move a couple things around WIP for manual test configuration generation

🤖 Implement config file generation for manual test

43d36fc

Fix build name

eccbeaf

WIP

a491588

WIP

9491067

Add secret generation stage

5fba197

Run pack-stage and generate-secrets-stage in parallel

9c32547

benrr101 added 20 commits May 28, 2026 13:24

🤖 Get connection string for setting up northwind from config

7b51688

🤖 Only swap out the initial catalog field.

3992b3c

🤖 vs 🤖 :fight:

96c193e

Sync config.cs and config.json

bdddb06

Cleanup powershells

61283a0

Config steps

349d7ec

🔨

0bda151

Diagnostic

c2e0ca9

Stupid powershell.

eb11519

Making demands.

dbd7d95

Fixing the first round of manual tests.

462253a

Increase timeout on sql notification test... not ideal but if it help…

8e15564

…s it helps.

Add retries to dotnet install steps

fabed09

Cleanup and add explicit disposal logic to AlwaysEncrypted.ApiShould.…

1aae60b

…TestExecuteReaderAsyncWithLargeQuery

Temporarily mark SqlNotificationTest.Test_SingleDependency_AllDefault…

a49c991

…s_SqlAuth as flay

Comments for pipeline, stages, jobs, variables.

772e925

Moving the SA password retrieval deeper into the manual test job

Fix SA password issue.

2934a36

🔨

357438e

Exclude AE ApiShould tests on debug builds.

27912d5

Address copilot feedback round 1 of n

3afd216

benrr101 force-pushed the dev/russellben/prci-buildstage branch from cda511d to 3afd216 Compare May 28, 2026 18:24

benrr101 commented May 28, 2026

View reviewed changes

Config.json changes applied to pipelines.

6419c73

Copilot AI review requested due to automatic review settings May 28, 2026 23:54

Copilot started reviewing on behalf of benrr101 May 28, 2026 23:54 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

benrr101 closed this May 29, 2026

github-project-automation Bot moved this from To triage to Done in SqlClient Board May 29, 2026

		@@ -4,11 +4,9 @@
		# See the LICENSE file in the project root for more information. #

Conversation

benrr101 commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Remaining work

Testing

Uh oh!

This comment was marked as outdated.

Uh oh!

edwardneal commented May 27, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

benrr101 commented May 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

edwardneal commented May 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

benrr101 commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

benrr101 commented May 26, 2026 •

edited

Loading