-
Notifications
You must be signed in to change notification settings - Fork 567
[TrimmableTypeMap] Root AndroidManifest-referenced types #11037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simonrozsival
wants to merge
14
commits into
main
Choose a base branch
from
dev/simonrozsival/root-manifest-referenced-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
99b1b3c
[TrimmableTypeMap] Root manifest-referenced types as unconditional
simonrozsival 57a5687
Address PR review: fix manifest name matching and null guard
simonrozsival f53f676
Document IsUnconditional mutation contract: only set to true
simonrozsival 4937f44
Fix RootManifestReferencedTypes: remove IO, add relative name resolution
simonrozsival 827da0d
[TrimmableTypeMap] Root Application and Instrumentation types
simonrozsival 7b6b48b
[TrimmableTypeMap] Match compat names in manifest rooting
simonrozsival ccb0cfd
[TrimmableTypeMap] Add coded warning for unresolved types
simonrozsival 0339fb5
[TrimmableTypeMap] Track manifest-related target inputs
simonrozsival f837d9a
[TrimmableTypeMap] Use switch expression for manifest names
simonrozsival 1bc4cff
Revert "[TrimmableTypeMap] Track manifest-related target inputs"
simonrozsival 7413d54
[TrimmableTypeMap] Merge manifest matching tests into theory
simonrozsival cac14e8
[TrimmableTypeMap] Fix theory package name
simonrozsival 116fa68
Fix manifest-rooting resolution and deferred registration
simonrozsival 6f42c3b
Add host test for placeholder-based typemap rooting
simonrozsival File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| --- | ||
| title: .NET for Android warning XA4250 | ||
| description: XA4250 warning code | ||
| ms.date: 04/07/2026 | ||
| f1_keywords: | ||
| - "XA4250" | ||
| --- | ||
|
|
||
| # .NET for Android warning XA4250 | ||
|
|
||
| ## Example message | ||
|
|
||
| Manifest-referenced type '{0}' was not found in any scanned assembly. It may be a framework type. | ||
|
|
||
| ```text | ||
| warning XA4250: Manifest-referenced type 'com.example.MainActivity' was not found in any scanned assembly. It may be a framework type. | ||
| ``` | ||
|
|
||
| ## Issue | ||
|
|
||
| The build found a type name in `AndroidManifest.xml`, but it could not match that name to any Java peer discovered in the app's managed assemblies. | ||
|
|
||
| This can be expected for framework-provided types, but it can also indicate that the manifest entry does not match the name generated for a managed Android component. | ||
|
|
||
| ## Solution | ||
|
|
||
| If the manifest entry refers to an Android framework type, this warning can usually be ignored. | ||
|
|
||
| Otherwise: | ||
|
|
||
| 1. Verify the `android:name` value in the manifest. | ||
| 2. Ensure the managed type is included in the app build. | ||
| 3. Check for namespace, `[Register]`, or nested-type naming mismatches between the manifest and the managed type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
src/Xamarin.Android.Build.Tasks/Properties/Resources.Designer.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.