[TrimmableTypeMap] Test plumbing and CI lane for Mono.Android.NET-Tests#11091
Draft
simonrozsival wants to merge 4 commits intodev/simonrozsival/trimmable-runtime-fixesfrom
Draft
Conversation
- Fix CRC64 algorithm (Jones instead of System.IO.Hashing) - Fix inherited override detection (walk past DoNotGenerateAcw bases) - Fix instrumentation targetPackage - JCW lazy registerNatives for App/Instrumentation types - Sanitize backtick in proxy names - Manifest name promotion and deferred registration propagation - Build targets and task updates - Typed logger interface - Unit test coverage Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- UCO constructors directly call activation ctor (no ActivateInstance indirection) - WithinNewObjectScope guard prevents double peer creation - No-op UCO for open generic type definitions - ControlFlowBuilder support in PEAssemblyBuilder - Remove TrimmableNativeRegistration wrapper and ActivateInstance Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- TrimmableTypeMap.TryGetType: unwrap proxy to return real managed type - TryGetJniName: fallback chain (Register → compat → JavaNativeTypeManager) - GetProxyForPeer: JNI class hierarchy walk with caching - CreatePeer: IsAssignableFrom validation for JavaCast safety - TypeManager/JNIEnv: trimmable guards for legacy APIs - JNIEnvInit: JniRuntime.SetCurrent for background threads Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use _AndroidTypeMapImplementation=trimmable directly instead of a MonoAndroidTypeMapFlavor wrapper property. This is consistent with the actual build system property used by the typemap targets. - _AndroidTypeMapImplementation=trimmable in CI yaml and test csproj - UseMonoRuntime=false set when _AndroidTypeMapImplementation=trimmable - TestsFlavor=CoreCLRTrimmable for result file naming - ExcludeCategories: NativeTypeMap, TrimmableIgnore, SSL - ExcludedTestNames for Java.Interop-Tests JavaObject-based fixtures Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
simonrozsival
force-pushed
the
dev/simonrozsival/trimmable-test-plumbing
branch
from
f8106b0 to
a437455
Compare
simonrozsival
added
trimmable-type-map
copilot
simonrozsival
force-pushed
the
dev/simonrozsival/trimmable-runtime-fixes
branch
from
d5aefaa to
3a8d509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4/4 — Test plumbing and CI lane
Depends on: #11090 (Runtime fixes)
Changes
_AndroidTypeMapImplementation=trimmablewithUseMonoRuntime=falseto run Mono.Android.NET-Tests with the trimmable typemap on CoreCLRCoreCLRTrimmableCI lane instage-package-tests.yamlNativeTypeMap,TrimmableIgnore,SSLfor trimmable runsJavaObjecttypes (notJava.Lang.Object) — these crash with SIGABRT because their hand-written Java helper classes (net.dot.jni.test.*) are not generated by the trimmable JCW processNewOpenGenericTypeThrows,ActivatedDirectThrowableSubclassesShouldBeRegistered,JavaCast_BaseToGenericWrapperLocal usage
Part of the series: PR 1 (Generator) → PR 2 (UCO) → PR 3 (Runtime) → PR 4