Onboard arcade-validation to OpenTelemetry Audit (OTel)#5500
Open
Onboard arcade-validation to OpenTelemetry Audit (OTel)#5500
Conversation
Add OTel Audit SDK instrumentation for privileged operations per S360 Service Layer Auditing requirements
missymessa
reviewed
Apr 10, 2026
| $ci = $true | ||
| . $PSScriptRoot\..\common\tools.ps1 | ||
| . $PSScriptRoot\..\common\pipeline-logging-functions.ps1 | ||
| . $PSScriptRoot\..\common\audit-logging.ps1 |
Member
There was a problem hiding this comment.
audit-logging.ps1 is in the validation folder, not common.
Member
|
I'd run this branch through https://dnceng.visualstudio.com/internal/_build?definitionId=282 to make sure it does what you expect it to. |
missymessa
reviewed
Apr 10, 2026
| string round0FilePath = Path.Combine(builder.TestRepoRoot, "artifacts", "tmp", "Release", "Signing", "Round0-Sign.proj"); | ||
| string round0ProjectText = File.ReadAllText(round0FilePath); | ||
| string expectedCert = useDotNetCert.GetValueOrDefault() ? DotNetCertificate : MicrosoftCertificate; | ||
| AuditHelper.LogControlPlane( |
Member
There was a problem hiding this comment.
Do you need to initialize AuditHelper?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item: https://dev.azure.com/dnceng/internal/_workitems/edit/10352
Add OTel Audit SDK instrumentation for privileged operations per S360 Service Layer Auditing requirements
Changes:
GetLocalIpAddress helper, and Golden Schema field population