Reduce unsafe usage in AdaptiveCapacityDictionary

[GrabYourPitchforks]

Removes unnecessary calls to the unsafe MemoryMarshal.GetArrayDataReference and MemoryMarshal.CreateSpan methods. The only thing this was doing was saving a single bounds check per call to FindIndex or TryFindItem, and this single bounds check is dwarfed by the call to IEqualityComparer<T>.Equals within the loop.

I hoisted the span into a local within the FindIndex method to ensure the bounds check occurs only once ahead of the loop, not within the loop itself.

[Copilot]

Pull request overview

This PR removes unnecessary unsafe memory operations from AdaptiveCapacityDictionary by replacing MemoryMarshal.GetArrayDataReference and MemoryMarshal.CreateSpan with the safer AsSpan method. The change also optimizes the FindIndex method by caching the span property access outside the loop.

• Simplified ArrayStorageSpan property to use AsSpan(0, _count) instead of unsafe MemoryMarshal APIs
• Optimized FindIndex by caching ArrayStorageSpan to avoid repeated property access within the loop

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[dotnet-policy-service]

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.