(follow-up) fix KeyRingProvider thread pool starvation on cold start#66743
Merged
DeagleGross merged 1 commit intoMay 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up nit cleanup to PR #66683. Simplifies the cold-start detection in KeyRingProvider.GetCurrentKeyRingCoreNew by using a null-coalescing assignment instead of a compound condition with a separate Volatile.Read, and trims the now-unnecessary comment.
The simplification is behaviorally equivalent: the only observable difference is that on the forceRefresh path existingCacheableKeyRing can now be assigned a non-null value, but the subsequent use of that variable on line 430 is gated by !forceRefresh, so no downstream behavior changes.
Changes:
- Replace
existingCacheableKeyRing is null && Volatile.Read(ref _cacheableKeyRing) is nullwithexistingCacheableKeyRing ??= Volatile.Read(ref _cacheableKeyRing); if (existingCacheableKeyRing is null). - Shorten the explanatory comment block accordingly.
Show a summary per file
| File | Description |
|---|---|
| src/DataProtection/DataProtection/src/KeyManagement/KeyRingProvider.cs | Minor refactor of the cold-start check to use ??=, plus comment cleanup. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
halter73
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A nit follow-up of #66683 based on #66736 (comment)