-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Move lengthy remarks for DynamicMethod to conceptual docs repo #51571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Moves long API reference remarks for System.Reflection.Emit.DynamicMethod into this conceptual docs repo to keep API docs concise while preserving detailed guidance.
Changes:
- Adds new “Supplemental API remarks” pages for
DynamicMethodmembers (constructors,CreateDelegate,GetILGenerator,Invoke, andIsSecurity*). - Updates
docs/fundamentals/toc.ymlto nest the new pages under the existing DynamicMethod entry. - Adds/updates snippet projects and sources referenced by the new conceptual pages.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/fundamentals/toc.yml | Nests DynamicMethod supplemental remark pages under the Reflection Emit TOC section. |
| docs/fundamentals/runtime-libraries/system-reflection-emit-dynamicmethod.md | Keeps type-level supplemental remarks, and updates xref formatting. |
| docs/fundamentals/runtime-libraries/system-reflection-emit-dynamicmethod-createdelegate.md | New supplemental remarks page for CreateDelegate overloads and examples. |
| docs/fundamentals/runtime-libraries/system-reflection-emit-dynamicmethod-ctor.md | New supplemental remarks page for constructors and security/visibility behavior. |
| docs/fundamentals/runtime-libraries/system-reflection-emit-dynamicmethod-getilgenerator.md | New supplemental remarks page for GetILGenerator overloads and examples. |
| docs/fundamentals/runtime-libraries/system-reflection-emit-dynamicmethod-invoke.md | New supplemental remarks page for Invoke, including behavior notes and examples. |
| docs/fundamentals/runtime-libraries/system-reflection-emit-dynamicmethod-issecuritycritical.md | New supplemental remarks page describing IsSecurity* transparency properties. |
| docs/fundamentals/runtime-libraries/includes/context.md | Changes the shared “supplementary remarks” banner to a NOTE block. |
| docs/fundamentals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/Overview/vb/source.vb | Adds VB overview snippet used by the new conceptual pages. |
| docs/fundamentals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/Overview/vb/Project.vbproj | Adds VB project file to build the overview snippet. |
| docs/fundamentals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/Overview/csharp/source.cs | Adds C# overview snippet used by the new conceptual pages. |
| docs/fundamentals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/Overview/csharp/Project.csproj | Adds C# project file to build the overview snippet. |
| docs/fundamentals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/.ctor/vb/source1.vb | Adds VB constructor snippet used by the constructors/CreateDelegate pages. |
| docs/fundamentals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/.ctor/vb/source.vb | Adds VB snippet demonstrating owner/type association and closed delegates. |
| docs/fundamentals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/.ctor/vb/Project.vbproj | Adds VB project file to build the .ctor snippets. |
| docs/fundamentals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/.ctor/csharp/source1.cs | Adds C# constructor snippet used by the constructors/CreateDelegate pages. |
| docs/fundamentals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/.ctor/csharp/source.cs | Adds C# snippet demonstrating owner/type association and closed delegates. |
| docs/fundamentals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/.ctor/csharp/Project.csproj | Adds C# project file to build the .ctor snippets. |
...entals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/Overview/vb/source.vb
Outdated
Show resolved
Hide resolved
docs/fundamentals/runtime-libraries/system-reflection-emit-dynamicmethod-issecuritycritical.md
Outdated
Show resolved
Hide resolved
...tals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/.ctor/csharp/source1.cs
Outdated
Show resolved
Hide resolved
...tals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/.ctor/csharp/source1.cs
Outdated
Show resolved
Hide resolved
...amentals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/.ctor/vb/source1.vb
Outdated
Show resolved
Hide resolved
...tals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/.ctor/csharp/source1.cs
Outdated
Show resolved
Hide resolved
...amentals/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/.ctor/vb/source1.vb
Outdated
Show resolved
Hide resolved
...ls/runtime-libraries/snippets/System.Reflection.Emit/DynamicMethod/Overview/csharp/source.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
meaghanlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes LGTM.
docs/fundamentals/runtime-libraries/system-reflection-emit-dynamicmethod-issecuritycritical.md
Show resolved
Hide resolved
…amicmethod-issecuritycritical.md
Move remarks > 15 lines to conceptual docs repo.
Contributes to dotnet/dotnet-api-docs#10722.
Internal previews