Translate COALESCE as ISNULL in more cases#35986
Open
ranma42 wants to merge 3 commits intodotnet:mainfrom
Open
Translate COALESCE as ISNULL in more cases#35986ranma42 wants to merge 3 commits intodotnet:mainfrom
ranma42 wants to merge 3 commits intodotnet:mainfrom
Conversation
5b4b67b to
4f4a019
Compare
Contributor
Author
|
Some additional notes: I tried to implement all of the suggestions by @roji and indeed they proved quite effective; OTOH the tests I added unveiled some additional limitations risks, which I mitigated with an approach the codebase is already taking elsewhere (basically widening the type).
Specifically the changes I implemented include:
The conversion now applies to all instances of
Even though it passes the testsuite, I think it might be a good idea to make it possible for users to opt-out, as I am afraid it might break some corner cases (especially around UDF and/or custom converters). |
249ae47 to
6b86657
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #34171 that extends the conversion to handle all of the cases (and adds a couple of tests for corner-cases).