[WIP] RFC-1331 Expression-scoped opens

[ijklam]

Description

Implements fsharp/fslang-suggestions#96
RFC fsharp/fslang-design#810

This PR only implements open in expressions. Open in type is not implemented.

Checklist

• Test cases added
• Release notes entry updated:
• Add language feature flag

[github-actions]

❗ Release notes required

@ijklam,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/10.0.200.md	No release notes found or release notes format is not correct

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
LanguageFeatures.fsi	docs/release-notes/.Language/preview.md

[ijklam]

This PR does not implement "open in types" feature. It needs some refactoring to implement the feature, which needs someone who knows a lot about the typechecking mechanics. I did make a prototype, but I am not satisfied on its restriction, working way and performance. It requires putting open declarations on the beginning of a type definition, and has bug in type ... and ... declaration. While typechecking, it need find and apply open declarations to the environment multiple times, and it causes the UnusedOpens.getUnusedOpens returning duplicated items for type-scoped opens. Also, when the line of open has error, it will raise multiple same error for it.

[T-Gro]

@ijklam : Thanks for the summary of the current state. I will convert the PR to a draft to prevent accidental merge for now.

[T-Gro]

@ijklam :
I thought about the remaining obstacles.

I think the 'open in expression' on its own would be a good addition and I believe scoping the feature between expressions and types could work.
'open in type' would then be a second part of the RFC, waiting to be implemented (by anyone brave enough to tackle it).

[ijklam]

'open in type' would then be a second part of the RFC, waiting to be implemented (by anyone brave enough to tackle it).

Actually the syntax node of "open in type"(SynMemberDefn.Open) exists from long time ago but no one implements the feature. Maybe it is too difficult 😄.