Fix :: FAR :: Remove corrupted .ctor symbol reference#19358
Merged
Conversation
Contributor
❗ Release notes required
|
Member
Author
|
I noticed some additional double reporting while fixing this, going older and caused by repeated Tc.Attrs. calls. (they had the right ranges, but were duplicates still) |
…t/fsharp into fix/symbols-duplicate-ctor # Conflicts: # tests/FSharp.Compiler.ComponentTests/FSharpChecker/FindReferences.fs
…licate attribute entries The PR removes the ForNewConstructors shifted-range hack (#14902) and suspends the sink during checkAttributeTargetsErrors, so tests no longer see those duplicate/corrupted symbol references. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
abonie
approved these changes
Feb 26, 2026
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
T-Gro
commented
Feb 26, 2026
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19336