Enhance the NameResolution System #19536
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| module Conformance.BasicGrammarElements.UseBindExtensionMethodCapture | ||
|
|
||
| open Xunit | ||
| open FSharp.Test.Compiler | ||
|
|
||
| [<Fact>] | ||
| let ``Use binding doesn't capture an extension method with generic type``() = | ||
| FSharp """ | ||
| open System | ||
| open System.Runtime.CompilerServices | ||
|
|
||
| type FooClass() = class end | ||
|
|
||
| type Disposable() = | ||
| interface IDisposable with | ||
| member _.Dispose() = () | ||
|
|
||
| [<Extension>] | ||
| type PublicExtensions = | ||
| [<Extension>] | ||
| static member inline Dispose(this: #FooClass) = | ||
| this | ||
|
|
||
| let foo() = | ||
| use a = new Disposable() | ||
| () | ||
|
|
||
| foo() | ||
| """ | ||
| |> asExe | ||
| |> compile | ||
| |> shouldSucceed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| module Conformance.Expressions.CEExtensionMethodCapture | ||
|
|
||
| open Xunit | ||
| open FSharp.Test.Compiler | ||
|
|
||
| [<Fact>] | ||
| let ``CE doesn't capture an extension method beyond the access domain``() = | ||
| FSharp """ | ||
| open System.Runtime.CompilerServices | ||
|
|
||
| type AsyncSeq<'T>(i: 'T) = | ||
| class | ||
| let l = [i] | ||
| member this.Data = l | ||
| end | ||
|
|
||
| type AsyncSeqBuilder() = | ||
| member _.Yield(x: 'T) : AsyncSeq<'T> = | ||
| AsyncSeq(x) | ||
|
|
||
| [<Extension>] | ||
| type PrivateExtensions = | ||
| [<Extension>] | ||
| static member inline private Run(this: AsyncSeqBuilder) = | ||
| this | ||
|
|
||
| let asyncSeq = AsyncSeqBuilder() | ||
|
|
||
| let xs : AsyncSeq<int> = | ||
| asyncSeq { | ||
| yield 1 | ||
| } | ||
| """ | ||
| |> asExe | ||
| |> compile | ||
| |> shouldSucceed | ||
|
|
||
| [<Fact>] | ||
| let ``CE doesn't capture an extension method with generic type``() = | ||
| FSharp """ | ||
| open System.Runtime.CompilerServices | ||
|
|
||
| type FooClass = class end | ||
|
|
||
| type AsyncSeq<'T>(i: 'T) = | ||
| class | ||
| let l = [i] | ||
| member this.Data = l | ||
| end | ||
|
|
||
| type AsyncSeqBuilder() = | ||
| member _.Yield(x: 'T) : AsyncSeq<'T> = | ||
| AsyncSeq(x) | ||
|
|
||
| [<Extension>] | ||
| type PublicExtensions = | ||
| [<Extension>] | ||
| static member inline Run(this: #FooClass) = | ||
| this | ||
|
|
||
| let asyncSeq = AsyncSeqBuilder() | ||
|
|
||
| let xs : AsyncSeq<int> = | ||
| asyncSeq { | ||
| yield 1 | ||
| } | ||
| """ | ||
| |> asExe | ||
| |> compile | ||
| |> shouldSucceed | ||
|
|
||
| // Deliberately trigger an error to ensure that a method is captured | ||
| [<Fact>] | ||
| let ``CE captures a public extension method and procudes an error due to invalid args``() = | ||
| FSharp """ | ||
| open System.Runtime.CompilerServices | ||
|
|
||
| type AsyncSeq<'T>(i: 'T) = | ||
| class | ||
| let l = [i] | ||
| member this.Data = l | ||
| end | ||
|
|
||
| type AsyncSeqBuilder() = | ||
| member _.Yield(x: 'T) : AsyncSeq<'T> = | ||
| AsyncSeq(x) | ||
|
|
||
| [<Extension>] | ||
| type PublicExtensions = | ||
| [<Extension>] | ||
| static member inline Run(this: AsyncSeqBuilder, invalidArg: string) = | ||
| this | ||
|
|
||
| let asyncSeq = AsyncSeqBuilder() | ||
|
|
||
| let xs : AsyncSeq<int> = | ||
| asyncSeq { | ||
| yield 1 | ||
| } | ||
| """ | ||
| |> asExe | ||
| |> compile | ||
| |> shouldFail | ||
|
|
||
| // Deliberately trigger an error to ensure that a method is captured | ||
| [<Fact>] | ||
| let ``CE captures a public extension method with valid generic constrainted type and procudes an error due to invalid args``() = | ||
| FSharp """ | ||
| open System.Runtime.CompilerServices | ||
|
|
||
| type AsyncSeq<'T>(i: 'T) = | ||
| class | ||
| let l = [i] | ||
| member this.Data = l | ||
| end | ||
|
|
||
| type AsyncSeqBuilder() = | ||
| member _.Yield(x: 'T) : AsyncSeq<'T> = | ||
| AsyncSeq(x) | ||
|
|
||
| [<Extension>] | ||
| type PublicExtensions = | ||
| [<Extension>] | ||
| static member inline Run(this: #AsyncSeqBuilder, invalidArg: string) = | ||
| this | ||
|
|
||
| let asyncSeq = AsyncSeqBuilder() | ||
|
|
||
| let xs : AsyncSeq<int> = | ||
| asyncSeq { | ||
| yield 1 | ||
| } | ||
| """ | ||
| |> asExe | ||
| |> compile | ||
| |> shouldFail | ||
|
Member
There was a problem hiding this comment. [Test Coverage] The existing tests all use [<Extension>]
type GenericExtensions =
[<Extension>]
static member inline Run(this: 'T) = thisThis would currently fail due to the |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering how is it already done in other cases? Is there a place that this function could be unified with?