[bgen] Enable nullability everywhere. by rolfbjarne · Pull Request #25023 · dotnet/macios

rolfbjarne · 2026-03-25T19:51:06Z

And fix any resulting issues.

Also add a convenience make target to build bgen.

Contributes towards #17285.

And fix any resulting issues. Also add a convenience make target to build bgen.

Copilot

Pull request overview

This PR enables nullable reference types across the bgen tool and adjusts the generator/tooling code to compile cleanly under #nullable enable, while also adding Makefile convenience targets to build/install bgen (part of the work toward #17285).

Changes:

Enabled #nullable enable in key bgen sources and updated signatures/annotations to reflect nullability.
Added/refactored helper APIs (e.g., TryCanRead/TryCanWrite/TryIsArray/..., GetOne*Attribute helpers) to reduce nullable warnings and tighten invariants.
Added bgen / install-bgen targets and factored DOTNET_BGEN_TARGETS in src/Makefile.generator.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/bgen/TypeManager.cs	Updated nullability of type-formatting helpers and related APIs.
src/bgen/Nomenclator.cs	Adjusted attribute lookup to nullable result.
src/bgen/Models/TrampolineInfo.cs	Made trampoline parameter names nullable to satisfy nullable flow.
src/bgen/Models/MemberInformation.cs	Nullability fixes in member metadata processing/casts.
src/bgen/Models/AsyncMethodInfo.cs	Allowed nullable category extension type in ctor signature.
src/bgen/Generator.cs	Broad nullability enablement + many flow tweaks and new “GetOne*” helpers.
src/bgen/Filters.cs	Added explicit null checks for required attributes; adjusted method signature.
src/bgen/Extensions/StringExtensions.cs	Made casing helpers null-safe + added nullability annotations.
src/bgen/Extensions/ExtensionMethods.cs	Added reflection/type helper `Try*` methods and nullability changes.
src/bgen/Enums.cs	Nullability enablement and safer dictionary lookups.
src/bgen/BindingTouch.cs	Null-forgiving for temp dir after initialization flow.
src/bgen/Attributes.cs	Enabled nullability and made multiple attribute properties nullable.
src/bgen/AttributeManager.cs	Enabled nullability and added `GetOneCustomAttribute` helper.
src/Makefile.generator	Added `bgen`/`install-bgen` targets and split bgen targets variable.

src/bgen/Generator.cs

The nullability changes accidentally dropped the 'virtual' keyword from GetCustomAttribute<T>, which broke Moq-based tests that mock this method. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…bgen

vs-mobiletools-engineering-service2 · 2026-03-31T08:56:50Z

✅ [PR Build #f0eb34f] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: f0eb34f8f752c0ab7bcec787b27c3af36d6c0025 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-31T09:09:13Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: f0eb34f8f752c0ab7bcec787b27c3af36d6c0025 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-31T10:53:03Z

✅ [CI Build #f0eb34f] Build passed (Build packages) ✅

Pipeline on Agent
Hash: f0eb34f8f752c0ab7bcec787b27c3af36d6c0025 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-31T11:19:56Z

✅ [CI Build #f0eb34f] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: f0eb34f8f752c0ab7bcec787b27c3af36d6c0025 [PR build]

vs-mobiletools-engineering-service2 · 2026-04-01T10:34:30Z

🚀 [CI Build #f0eb34f] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 156 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ generator: All 5 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: f0eb34f8f752c0ab7bcec787b27c3af36d6c0025 [PR build]

[bgen] Enable nullability everywhere.

5fd79fa

And fix any resulting issues. Also add a convenience make target to build bgen.

rolfbjarne requested a review from Copilot March 25, 2026 19:51

Copilot started reviewing on behalf of rolfbjarne March 25, 2026 19:51 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

src/bgen/Generator.cs Show resolved Hide resolved

Auto-format source code

416905f

This comment has been minimized.

Sign in to view

GitHub Actions Autoformatter and others added 2 commits March 26, 2026 12:50

Auto-format source code

5f0a0d9

[bgen] Restore virtual keyword on GetCustomAttribute<T>.

34e20f0

The nullability changes accidentally dropped the 'virtual' keyword from GetCustomAttribute<T>, which broke Moq-based tests that mock this method. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review March 30, 2026 07:06

rolfbjarne enabled auto-merge (squash) March 30, 2026 07:06

dalexsoto approved these changes Mar 30, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into dev/rolf/nullability-…

4adce0d

…bgen

This comment has been minimized.

Sign in to view

Fix

f0eb34f

This comment has been minimized.

Sign in to view

rolfbjarne merged commit d0d53e8 into main Apr 1, 2026
48 checks passed

Conversation

rolfbjarne commented Mar 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 31, 2026

✅ [PR Build #f0eb34f] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 31, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 31, 2026

✅ [CI Build #f0eb34f] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 31, 2026

✅ [CI Build #f0eb34f] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 1, 2026

🚀 [CI Build #f0eb34f] Test results 🚀

Test results

Tests counts

macOS tests

Linux Build Verification

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants