Skip to content

Add missing GC.KeepAlives to WMIInterop #124796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EgorBo wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

Add missing GC.KeepAlives to WMIInterop #124796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/libraries/System.Management/src/System/Management/InteropClasses/WMIInterop.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ public int CompareTo_(int lFlags, IWbemClassObjectFreeThreaded pCompareTo)
if (pWbemClassObject == IntPtr.Zero)
throw new ObjectDisposedException(name);
int res = WmiNetUtilsHelper.CompareTo_f(16, pWbemClassObject, lFlags, pCompareTo.pWbemClassObject);
GC.KeepAlive(pCompareTo);
GC.KeepAlive(this);
return res;
}
Expand Down Expand Up @@ -270,6 +271,8 @@ public int PutMethod_(string wszName, int lFlags, IWbemClassObjectFreeThreaded p
if (pWbemClassObject == IntPtr.Zero)
throw new ObjectDisposedException(name);
int res = WmiNetUtilsHelper.PutMethod_f(20, pWbemClassObject, wszName, lFlags, pInSignature, pOutSignature);
Copy link
Member Author

@EgorBo EgorBo Feb 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may look like we pass objects directly here, but it's just an overriden operator:

internal sealed class IWbemClassObjectFreeThreaded : IDisposable
{
    private IntPtr pWbemClassObject = IntPtr.Zero;

    public static implicit operator IntPtr(IWbemClassObjectFreeThreaded wbemClassObject)
    {
        if (null == wbemClassObject)
            return IntPtr.Zero;
        return wbemClassObject.pWbemClassObject;
    }

GC.KeepAlive(pInSignature);
GC.KeepAlive(pOutSignature);
GC.KeepAlive(this);
return res;
}
Expand Down
Loading