Move _LinkedResolvedFileToPublishCandidate computation to after PrepareForILLink#124812
Draft
Move _LinkedResolvedFileToPublishCandidate computation to after PrepareForILLink#124812
_LinkedResolvedFileToPublishCandidate computation to after PrepareForILLink#124812Conversation
…reForILLink Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
dotnet-policy-service
bot
added
the
linkable-framework
Copilot
AI
changed the title
[WIP] Ensure per-assembly metadata flows to ResolvedFileToPublish
Move Feb 24, 2026
_LinkedResolvedFileToPublishCandidate computation to after PrepareForILLink
github-actions
bot
added
the
area-Tools-ILLink
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/illink |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_LinkedResolvedFileToPublishCandidatewas computed inside_ComputeManagedAssemblyToLink, beforePrepareForILLinkruns. Per-assembly metadata added toManagedAssemblyToLinkbyPrepareForILLink(or targets hooking in viaBeforeTargets/AfterTargets) was therefore lost and never flowed through toResolvedFileToPublish.Changes
_ComputeLinkedResolvedFileToPublishCandidatetarget (DependsOnTargets="PrepareForILLink") — moves the_LinkedResolvedFileToPublishCandidateItemGroup computation to afterPrepareForILLinkand all its hooks have run, so item metadata is captured correctly._RunILLinkDependsOnTargetsupdated from_ComputeManagedAssemblyToLink;PrepareForILLinkto_ComputeLinkedResolvedFileToPublishCandidate; all prior dependencies are transitively covered.Target execution order (after fix)
_ComputeManagedAssemblyToLink(+AfterTargetshooks, e.g. NativeAOT's_ComputeManagedAssemblyForILLink)PrepareForILLink(+BeforeTargets/AfterTargetshooks adding per-assembly metadata)_ComputeLinkedResolvedFileToPublishCandidate← new; sees fully-annotatedManagedAssemblyToLink_RunILLink→ILLink→ResolvedFileToPublishpopulated with correct metadata🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.