Skip to content

[cDAC] Handle VirtualReadException in StackWalk_1.IsManaged() #124844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
max-charlamb wants to merge 1 commit into from
Closed

[cDAC] Handle VirtualReadException in StackWalk_1.IsManaged() #124844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...dac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/StackWalk_1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,18 @@ private bool IsManaged(TargetPointer ip, [NotNullWhen(true)] out CodeBlockHandle
{
IExecutionManager eman = _target.Contracts.ExecutionManager;
TargetCodePointer codePointer = CodePointerUtils.CodePointerFromAddress(ip, _target);
if (eman.GetCodeBlockHandle(codePointer) is CodeBlockHandle cbh && cbh.Address != TargetPointer.Null)
try
{
codeBlockHandle = cbh;
return true;
if (eman.GetCodeBlockHandle(codePointer) is CodeBlockHandle cbh && cbh.Address != TargetPointer.Null)
{
codeBlockHandle = cbh;
return true;
}
}
catch (VirtualReadException)
{
// If we fail to read memory while looking up the code block, the IP is not in managed code
Copy link
Member

@jkotas jkotas Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we fail to read memory while looking up the code block, the IP is not in managed code

How can this happen? I do not think we should ever fail to read the memory (unless the data are corrupted or missing - but then we cannot really tell whether the IP is in managed code or not).

// (or the data is corrupted). Treat as not managed and continue the walk.
}
codeBlockHandle = default;
return false;
Expand Down
Loading