-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[WBT] enable coreCLR #124850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WBT] enable coreCLR #124850
Changes from all commits
4a3cbb0
8e8806c
10c3308
16535e5
0b92d26
3bc6c76
e7f36c4
c3c7d7c
be5b8a1
760be21
93ee02b
9165e9c
e137e32
ad337a3
d3e3fd4
61178e4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| Wasm.Build.Tests.DebugLevelTests | ||
| Wasm.Build.Tests.EnvVariablesTests | ||
| Wasm.Build.Tests.FilesToIncludeInFileSystemTests | ||
| Wasm.Build.Tests.HttpTests | ||
| Wasm.Build.Tests.LazyLoadingTests | ||
| Wasm.Build.Tests.ModuleConfigTests | ||
| Wasm.Build.Tests.PreloadingTests | ||
| Wasm.Build.Tests.RebuildTests | ||
| Wasm.Build.Tests.SatelliteLoadingTests | ||
| Wasm.Build.Tests.WasmBuildAppTest | ||
| Wasm.Build.Tests.WasmRunOutOfAppBundleTests | ||
| Wasm.Build.Tests.WasmTemplateTests |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,13 +43,20 @@ | |
| <_BuildWasmAppsPayloadArchive>@(_WasmWorkItem)</_BuildWasmAppsPayloadArchive> | ||
| </PropertyGroup> | ||
|
|
||
| <ReadLinesFromFile File="$(BuildWasmAppsJobsList)" Condition="Exists($(BuildWasmAppsJobsList)) and '$(TestUsingWorkloads)' == 'true'"> | ||
| <ReadLinesFromFile File="$(BuildWasmAppsJobsList)" Condition="Exists($(BuildWasmAppsJobsList))"> | ||
| <Output TaskParameter="Lines" ItemName="BuildWasmApps_PerJobList" /> | ||
| </ReadLinesFromFile> | ||
|
|
||
| <!-- for testing with workloads, we use separate items --> | ||
| <ItemGroup> | ||
| <HelixWorkItem Include="@(BuildWasmApps_PerJobList->'$(WorkItemPrefix)%(Identity)')" Condition="'$(TestUsingWorkloads)' == 'true' and '$(WasmFingerprintAssets)' == 'true' and '$(WasmBundlerFriendlyBootConfig)' == 'false'"> | ||
| <HelixWorkItem Include="@(BuildWasmApps_PerJobList->'$(WorkItemPrefix)%(Identity)')" Condition="'$(RuntimeFlavor)' == 'Mono' and '$(TestUsingWorkloads)' == 'true' and '$(WasmFingerprintAssets)' == 'true' and '$(WasmBundlerFriendlyBootConfig)' == 'false'"> | ||
| <PayloadArchive>$(_BuildWasmAppsPayloadArchive)</PayloadArchive> | ||
| <PreCommands>$(EnvVarCommand) "HELIX_XUNIT_ARGS=-class %(Identity)"</PreCommands> | ||
| <Command>$(HelixCommand)</Command> | ||
| <Timeout>$(_workItemTimeout)</Timeout> | ||
| </HelixWorkItem> | ||
|
|
||
| <HelixWorkItem Include="@(BuildWasmApps_PerJobList->'$(WorkItemPrefix)%(Identity)')" Condition="'$(RuntimeFlavor)' == 'CoreCLR' and '$(WasmFingerprintAssets)' == 'true' and '$(WasmBundlerFriendlyBootConfig)' == 'false'"> | ||
| <PayloadArchive>$(_BuildWasmAppsPayloadArchive)</PayloadArchive> | ||
| <PreCommands>$(EnvVarCommand) "HELIX_XUNIT_ARGS=-class %(Identity)"</PreCommands> | ||
| <Command>$(HelixCommand)</Command> | ||
|
Comment on lines
+59
to
62
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduces a new CoreCLR-specific jobs list file (
BuildWasmAppsJobsListCLR.txt), buteng/pipelines/common/evaluate-default-paths.ymlonly referencesBuildWasmAppsJobsList.txt. As a result, future edits to the CoreCLR list may not trigger the intended WASM/BuildWasmApps pipeline subsets. Please addeng/testing/scenarios/BuildWasmAppsJobsListCLR.txtto the evaluated path sets alongside the existing Mono list.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot implement the suggestion directly on this branch