Fix ToolBarTray negative measure constraint#11648
Open
eolivesjoe wants to merge 1 commit into
Open
Conversation
dotnet-policy-service
Bot
added
PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2189
Description
ToolBarTray.MeasureOverride used DoubleUtil.LessThan(remainingLength, 0) when deciding whether to clamp remainingLength to zero.
Because DoubleUtil.LessThan uses an epsilon comparison, a very small negative value may not be treated as less than zero. That value can then be used as a measure constraint, which can result in an ArgumentException.
This changes the guard to use a direct negative check so any negative remainingLength is clamped before it is used during measure.
Customer Impact
Customers can hit an ArgumentException during ToolBarTray layout measurement when floating-point rounding leaves remainingLength slightly negative.
Regression
No.
Testing
Built locally with .\build.cmd
Risk
Low. The change is limited to ToolBarTray.MeasureOverride and only affects negative remainingLength values.
Microsoft Reviewers: Open in CodeFlow