-
Notifications
You must be signed in to change notification settings - Fork 158
FIX error when doing sed on non existing privoxy config file #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Are you sure that this is a fix? Because you'll get an empty config for |
|
It works for me at least. |
They're not filling the file. Did you check it's content after the build? |
skobkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably bring the old /etc/privoxy/config to the repository and add it using COPY. But you'll need to check that it works well first.
Currently the image will built successfully, but only Tor part of it will be working as intended. So there is no point in such changes, you can just use image which only contains Tor itself.
| apk --no-cache --no-progress add bash curl privoxy shadow tini tor tzdata&&\ | ||
| apk --no-cache --no-progress add bash curl privoxy shadow tini tor tzdata && \ | ||
| file='/etc/privoxy/config' && \ | ||
| touch $file && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command just creates an empty file.
The following sed commands are doing nothing after that. So after this fix privoxy will not function as intended by the maintainer.
|
Installing privoxy nowadays adds '.new' to its default config files under /etc/privoxy. I maintain an up to date version under https://github.com/SimonHaas/torproxy |
When doing a full build from the

Dockerfilein the repo, I got this error because theRUNcommand tries to runsedon a file that does not exist.This commit ensures that the privoxy config file exists, before working with it.