gguf: optimize prefill speeds for Q4_K quants#1395
Open
AlpinDale wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our prefill is currently 8x slower than native llama.cpp. This is an attempt at closing that gap.
Llama 3.1 8B Q4_K_M, RTX 3090
Main
PR
Baseline (llama.cpp)
Note that the decode numbers for llama.cpp are closer to ours, these tests were run with top_k=vocab_size, which llama.cpp struggles with.
There's still a lot of room for optimization, and it needs to be extended to other quant types as well. For now, this provides a huge prefill throughput improvement over main. The optimizations here are quite conservative to avoid some NaN output issues I ran into, so there's still room for way more aggressive approaches.