feat: add fixpack plugin to sort package.json#28
Open
aminya wants to merge 6 commits intodprint:mainfrom
Open
Conversation
dsherret
requested changes
Jul 1, 2022
Member
dsherret
left a comment
dsherret
left a comment
There was a problem hiding this comment.
Thanks, but a test for this would be useful in ./test/specs as well. (by the way, let me know if you would like me to do it)
dsherret
force-pushed
the
main
branch
2 times, most recently
from
f995ecc to
7e2fe5a
Compare
Contributor
Author
|
The plugin uses fs and path modules. Is it fine to bundle for Nodejs? Edit: awaiting #27 |
Contributor
Author
|
The main function's stack is overflowed! Not sure what is causing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16