Add support for connection_pool >= 3.0#163
Conversation
af23b93 to
27e8f12
Compare
27e8f12 to
b0f457a
Compare
|
Should someone be tagged to take a look at this? Probably blocking a lot of folks from upgrading sidekiq |
|
@tenderlove when you have a second, could you take a look at this? |
|
Ooof. Thanks for being persistent (lol). It looks good, I'll merge and release after CI returns. |
|
I think we should also update ubuntu version since 20.04 is removed |
I sent a PR to modernize CI. Unfortunately it seems like we have some legit failures on modern Ruby #165 I'll try to get it fixed and then ship all of these. |
|
This should be shipped now as v4.0.7. I've also switched the release process to use trusted publishing. If there's any problems, please let me know and I'll ship a new version! |
|
@tenderlove thank you, works as expected |
Pool#initializewas simplified to use**optionssyntax (compatible with both versions), whileTimedStackMulti#initializeuses conditional logic based on ConnectionPool version due to different subclass super() behavior.{ connection_args: popped }as theobj(https://github.com/mperham/connection_pool/blob/v2.5.5/lib/connection_pool/timed_stack.rb#L38) ?So I added the
connection_argswith another value for clear separation ofobjandoptions(https://github.com/mperham/connection_pool/blob/v3.0.2/lib/connection_pool/timed_stack.rb#L38)to make the tests more clear.