Updated Javascript and Ruby on Rails DB Model to account for the *reserved word* 'end' it is now 'ends'#1
Open
seanjhulse wants to merge 1 commit intodriftingruby:masterfrom
Open
Conversation
…erved word* 'end'. It is now 'ends'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reserved word 'end' that we used in the database caused some issues with my application when I needed to make some special Active Record queries like
...where('end > ?', Date.today)I changed the word 'end' to 'ends' so it remained intuitive (and was easy to update on all of my files). I hope I got all of the reserved words out of Ruby code. I ran it on my end and it went fine, but perhaps I got lucky. If it is all fixed, Active Record queries now look like
...where('ends > ?', Date.today)