Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies the GitHub Actions workflow configurations to simplify the release pipeline and broaden the quality check triggers. It removes the manual dispatch option and several jobs from the release workflow, and loosens branch filters on the check workflow.
Changes:
- Removes
workflow_dispatchtrigger, therelease-plz-prjob, and thebuild-binariesjob from the release workflow, leaving only the corerelease-plzrelease step. - Removes branch filters (
main) frompushandpull_requesttriggers in the quality check workflow, causing it to run on all branches. - Bumps
actions/checkoutfromv4tov5in the check workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
Removes workflow_dispatch, simplifies the if condition, and removes release-plz-pr and build-binaries jobs. |
.github/workflows/check.yaml |
Removes branch filters from push/pull_request triggers; bumps actions/checkout to v5. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -3,11 +3,7 @@ name: Quality Check | |||
| on: | |||
| workflow_call: | |||
| push: | |||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.