fix: allow placeholders in SQLite onConflictDoUpdate set clause #5097
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5084
Problem
The TypeScript types for onConflictDoUpdate's set clause did not allow sql.placeholder values, even though they work correctly at runtime. This prevented users from using placeholders in upsert operations with prepared statements.
Solution
Added Placeholder to the SQLiteUpdateSetSource type definition in src/sqlite-core/query-builders/update.ts
Changes
Modified SQLiteUpdateSetSource type to include | Placeholder in the union type
Added type test type-tests/sqlite/issue-5084.ts to verify the fix
Testing
Created a reproduction test case in type-tests/sqlite/issue-5084.ts that verifies sql.placeholder can now be used in
onConflictDoUpdate set clause
Verified locally by running npm run test:types
Confirmed the test fails without the fix and passes with the fix