Conversation
artwyman
left a comment
There was a problem hiding this comment.
It looks to me like this PR contains more changes than those described in the title and description. For instance the CMAKE_DEBUG_POSTFIX seems like a library-naming change which would break compatibility, so would need some justification.
Since we don't use CMake with json11 at Dropbox, I'd be curious to hear commentary from the other community-members who have contributed to this config, such as @4brunu and @admsyn.
|
This PR goes behind my CMake knowledge, but I tested this change in one of my projects and it works. |
So you can easily use installed builds from other CMake projects by setting json11_DIR.
1b25055 to
5b82ec0
Compare
|
I removed appending |
|
I'm still using json11 and I'm still using CMake. A merge of this PR or a comment on how to make it ready-to-be-merged would really help me in my day-to-day worklife :) |
Let CMake create and install json11Config.cmake allowing other CMake projects to easily import json11 as a CMake-target by setting
json11_DIRto the corresponding location.