Skip to content

Conversation

@wiasliaw
Copy link

Close #324.

@vercel
Copy link

vercel bot commented Apr 22, 2025

@wiasliaw is attempting to deploy a commit to the Duneanalytics Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@2xic 2xic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! Just a minor comment

@cursor
Copy link

cursor bot commented Dec 22, 2025

PR Summary

Revamps 0x08 precompile docs to detail bn128 G1/G2 encoding, rename inputs to explicit component fields, and add an example with playground link.

  • Docs (precompile 0x08, Byzantium bn128 pairing):
    • Clarify encoding for G_1 over F_p and G_2 over F_{p^2} (including point-at-infinity encoding).
    • Update inputs schema: rename from x1/y1/x2/y2/x3/y3 to explicit components g1_x, g1_y, g2_x_c1, g2_x_c0, g2_y_c1, g2_y_c0; emphasize inputs are multiples of 6×32 bytes.
    • Add example input/output and a playground reproduction link.

Written by Cursor Bugbot for commit 5659ec8. Configure here.

@wiasliaw
Copy link
Author

wiasliaw commented Dec 22, 2025

@2xic
I had fixed the comment.
feel free for any comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect description about ecPairing

2 participants