Skip to content

perf(canvas): reduce Konva churn during pan/drag in control layers #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

perf(canvas): reduce Konva churn during pan/drag in control layers #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98d0863
Initial plan
Copilot Mar 2, 2026
ab5dd00
perf: throttle stage drag sync and reuse background grid lines
Copilot Mar 2, 2026
76eddb6
perf: cleanup throttled stage sync and optimize grid line trimming
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions invokeai/frontend/web/src/features/controlLayers/konva/CanvasBackgroundModule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,36 +161,52 @@ export class CanvasBackgroundModule extends CanvasModuleBase {
let _x = 0;
let _y = 0;

this.konva.linesGroup.destroyChildren();
this.konva.lines = [];
const totalLines = xSteps + ySteps;

this.konva.lines.splice(totalLines).forEach((line) => line.destroy());

let lineIndex = 0;
for (let i = 0; i < xSteps; i++) {
_x = gridFullRect.x1 + i * gridSpacing;
const line = new Konva.Line({
const line =
this.konva.lines[lineIndex] ??
new Konva.Line({
listening: false,
perfectDrawEnabled: false,
});
line.setAttrs({
x: _x,
y: gridFullRect.y1,
points: [0, 0, 0, ySize],
stroke: _x % 64 ? this.config.GRID_LINE_COLOR_FINE : this.config.GRID_LINE_COLOR_COARSE,
strokeWidth,
listening: false,
perfectDrawEnabled: false,
});
this.konva.lines.push(line);
this.konva.linesGroup.add(line);
this.konva.lines[lineIndex] = line;
if (line.getParent() !== this.konva.linesGroup) {
this.konva.linesGroup.add(line);
}
lineIndex += 1;
}
for (let i = 0; i < ySteps; i++) {
_y = gridFullRect.y1 + i * gridSpacing;
const line = new Konva.Line({
const line =
this.konva.lines[lineIndex] ??
new Konva.Line({
listening: false,
perfectDrawEnabled: false,
});
line.setAttrs({
x: gridFullRect.x1,
y: _y,
points: [0, 0, xSize, 0],
stroke: _y % 64 ? this.config.GRID_LINE_COLOR_FINE : this.config.GRID_LINE_COLOR_COARSE,
strokeWidth,
listening: false,
perfectDrawEnabled: false,
});
this.konva.lines.push(line);
this.konva.linesGroup.add(line);
this.konva.lines[lineIndex] = line;
if (line.getParent() !== this.konva.linesGroup) {
this.konva.linesGroup.add(line);
}
lineIndex += 1;
}
};

Expand Down
8 changes: 7 additions & 1 deletion invokeai/frontend/web/src/features/controlLayers/konva/CanvasStageModule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import type { Coordinate, Dimensions, Rect, StageAttrs } from 'features/controlL
import Konva from 'konva';
import type { KonvaEventObject } from 'konva/lib/Node';
import { atom, computed } from 'nanostores';
import rafThrottle from 'raf-throttle';
import type { Logger } from 'roarr';

type CanvasStageModuleConfig = {
Expand Down Expand Up @@ -488,9 +489,13 @@ export class CanvasStageModule extends CanvasModuleBase {
return;
}

this.syncStageAttrs();
this.syncStageAttrsThrottled();
};

syncStageAttrsThrottled = rafThrottle(() => {
this.syncStageAttrs();
});

onStageDragEnd = (e: KonvaEventObject<DragEvent>) => {
if (e.target !== this.konva.stage) {
return;
Expand Down Expand Up @@ -592,6 +597,7 @@ export class CanvasStageModule extends CanvasModuleBase {

destroy = () => {
this.log.debug('Destroying module');
this.syncStageAttrsThrottled.cancel();
this.subscriptions.forEach((unsubscribe) => unsubscribe());
this.subscriptions.clear();
if (this.resizeObserver) {
Expand Down