Skip to content

Fix VAT Group prices and Expose Connector#64

Merged
DWDBE merged 8 commits into
mainfrom
dbe/28202-28164-Fix-VatGroup-prices-Expose-Connector
May 13, 2026
Merged

Fix VAT Group prices and Expose Connector#64
DWDBE merged 8 commits into
mainfrom
dbe/28202-28164-Fix-VatGroup-prices-Expose-Connector

Conversation

@DWDBE
Copy link
Copy Markdown
Contributor

@DWDBE DWDBE commented May 12, 2026

#28202: Fix product prices for the VAT Group (when no ProductPriceWithVat value is in the response xml)
#28164: Expose Connector for extensibility use

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Live Integration pricing to correctly derive VAT-inclusive amounts when the ERP response omits TotalPriceWithVat (notably for VAT Group pricing), and exposes the Connector API for extensibility scenarios.

Changes:

  • Extends GetPriceInfo to accept the Product instance and uses it when calculating VAT-inclusive prices via PriceCalculated.
  • Updates price-provider call sites and example override to use the new GetPriceInfo overload (keeps the old overload as [Obsolete]).
  • Makes Connectors.Connector public (and exposes RetrievePDF publicly) and bumps package version.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Products/ProductProviderBase.cs Adds new GetPriceInfo overload carrying Product through VAT calculation path; retains obsolete overload.
src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Products/ProductPriceProvider.cs Updates callers to pass Product into the new pricing APIs.
src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Dynamicweb.Ecommerce.DynamicwebLiveIntegration.csproj Version bump 10.4.3510.4.36.
src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Connectors/Connector.cs Exposes Connector publicly and makes RetrievePDF public for extensibility.
src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration.Examples/CustomProductProvider.cs Updates example override to the new GetPriceInfo signature.
Comments suppressed due to low confidence (1)

src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Connectors/Connector.cs:363

  • RetrievePDF is now public, but it has no XML documentation while the other public methods in this class do. Add a <summary> (and relevant <param>/<returns> tags) so the newly public API is documented consistently.
        public static string RetrievePDF(Settings settings, string requestString, SubmitType submitType)
        {
            Diagnostics.ExecutionTable.Current.Add("DynamicwebLiveIntegration.Connector.RetrievePDF START");
            string base64EncodedPDF;
            var logger = new Logger(settings);
            try

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…on references from 'product' to 'productInfo'

Agent-Logs-Url: https://github.com/dynamicweb/DataIntegration.LiveIntegration/sessions/109a717e-4ead-4d8d-98c7-26b0c32530f2

Co-authored-by: MatthiasSort <123721955+MatthiasSort@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Connectors/Connector.cs:363

  • RetrievePDF is now a public API surface, but it doesn't have XML documentation while the other public methods on Connector do. Add // docs (and, if relevant, document that it logs the request/response and rethrows on errors) to keep the public API consistent and discoverable.
        public static string RetrievePDF(Settings settings, string requestString, SubmitType submitType)
        {
            Diagnostics.ExecutionTable.Current.Add("DynamicwebLiveIntegration.Connector.RetrievePDF START");
            string base64EncodedPDF;
            var logger = new Logger(settings);
            try

DWDBE and others added 3 commits May 12, 2026 17:39
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

DWDBE and others added 3 commits May 12, 2026 21:39
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@DWDBE DWDBE merged commit 979d58b into main May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants