Search Typeahead - Correction to styling issue with highligting of dropdown results #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Not sure we agree it should be like that... The current behavior is based off how other search engines behave:
Also we try to adhere to UX guidelines from sources like Baymard: |
Author
|
Hi Nikolaj.
Given that Swift is highlighting what is suggested, maybe theres an issue with Swift only highlighing the text after the search term (Not addressed in this PR). When searching for "road" I would think that "scattante ssr" also should be highlighted, as it is suggested? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There currently a styling issue with highligting of the dropdown results.
It marks everything after the searchTerm. The fix was quite simple.
Before
After
