Add Goose skills support (.goose/skills/)#1149
Open
github-actions[bot] wants to merge 7 commits intomainfrom
Open
Add Goose skills support (.goose/skills/)#1149github-actions[bot] wants to merge 7 commits intomainfrom
github-actions[bot] wants to merge 7 commits intomainfrom
Conversation
Owner
|
\oc レビューお願い |
Owner
|
/oc レビューお願い |
This comment has been minimized.
This comment has been minimized.
Owner
|
/oc #1149 (comment) このレビューコメントの指摘を修正してください。 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Owner
|
/oc review |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: dyoshikawa <dyoshikawa@users.noreply.github.com>
Co-authored-by: dyoshikawa <dyoshikawa@users.noreply.github.com>
192c329 to
a581d27
Compare
Owner
|
/oc review |
Owner
|
/oc review |
This comment has been minimized.
This comment has been minimized.
Owner
|
/oc review |
Contributor
Author
PR #1149 Review: Add Goose Skills SupportCode Review SummaryOverall Assessment: ⭐ 4/5 - Request Changes ✅ Strengths
🔴 Blocking IssueDocumentation Markdown Formatting Error ( The Goose skills section has malformed code fence closing - extra `````` on line 193 will render improperly. 🟡 Minor Issues
Security Review SummaryOverall Risk Level: LOW ✅ - APPROVE
The implementation properly inherits security protections and follows established secure patterns. Action Required Before Merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation complete. I've added Goose skills support with the following changes:
src/features/skills/goose-skill.ts- NewGooseSkillclass that:.goose/skills/<name>/SKILL.mdnameanddescriptionfrontmatter"goose"or"*"in rulesync skill targetssrc/features/skills/skills-processor.ts- Registeredgoosetarget in:skillsProcessorToolTargetTupletoolSkillFactoriesmap withsupportsProject: true, supportsSimulated: false, supportsGlobal: falsesrc/features/skills/goose-skill.test.ts- 13 tests covering all methodssrc/features/skills/skills-processor.test.ts- Updated expected targets to includegooseCloses #1115
github run