Skip to content

Add Goose skills support (.goose/skills/)#1149

Open
github-actions[bot] wants to merge 7 commits intomainfrom
opencode/issue1115-20260221073034
Open

Add Goose skills support (.goose/skills/)#1149
github-actions[bot] wants to merge 7 commits intomainfrom
opencode/issue1115-20260221073034

Conversation

@github-actions
Copy link
Contributor

Implementation complete. I've added Goose skills support with the following changes:

  1. src/features/skills/goose-skill.ts - New GooseSkill class that:

    • Generates skills to .goose/skills/<name>/SKILL.md
    • Follows the Agent Skills specification with name and description frontmatter
    • Supports project scope only (no global mode)
    • Targeted by "goose" or "*" in rulesync skill targets
  2. src/features/skills/skills-processor.ts - Registered goose target in:

    • skillsProcessorToolTargetTuple
    • toolSkillFactories map with supportsProject: true, supportsSimulated: false, supportsGlobal: false
  3. src/features/skills/goose-skill.test.ts - 13 tests covering all methods

  4. src/features/skills/skills-processor.test.ts - Updated expected targets to include goose

Closes #1115

github run

@dyoshikawa
Copy link
Owner

\oc レビューお願い

@dyoshikawa
Copy link
Owner

/oc レビューお願い

@github-actions

This comment has been minimized.

@dyoshikawa
Copy link
Owner

/oc #1149 (comment) このレビューコメントの指摘を修正してください。

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@dyoshikawa
Copy link
Owner

/oc review

@github-actions

This comment has been minimized.

dyoshikawa and others added 4 commits February 23, 2026 22:55
@dyoshikawa-claw dyoshikawa-claw force-pushed the opencode/issue1115-20260221073034 branch from 192c329 to a581d27 Compare February 23, 2026 13:55
@dyoshikawa
Copy link
Owner

/oc review

@dyoshikawa
Copy link
Owner

/oc review

@github-actions

This comment has been minimized.

@dyoshikawa
Copy link
Owner

/oc review

@github-actions
Copy link
Contributor Author

PR #1149 Review: Add Goose Skills Support

Code Review Summary

Overall Assessment: ⭐ 4/5 - Request Changes

✅ Strengths

  • Excellent pattern adherence (mirrors ReplitSkill, KiroSkill, CursorSkill)
  • Proper type safety with z.looseObject() schema
  • Complete static method implementation
  • Name matching validation (frontmatter name matches directory)
  • Correct SkillsProcessor integration
  • Good test coverage (13 tests)

🔴 Blocking Issue

Documentation Markdown Formatting Error (docs/reference/file-formats.md, skills/rulesync/file-formats.md)

The Goose skills section has malformed code fence closing - extra `````` on line 193 will render improperly.

🟡 Minor Issues

  • Missing test for invalid frontmatter (missing description)
  • Missing constructor test for name mismatch validation

Security Review Summary

Overall Risk Level: LOW ✅ - APPROVE

Area Status
Path Traversal ✅ Protected via AiDir base class
Input Validation ✅ Zod schema + name-directory consistency check
Injection ✅ None found
Global Mode ✅ Correctly throws error

The implementation properly inherits security protections and follows established secure patterns.


Action Required Before Merge

  1. Required: Fix code fence formatting in docs/reference/file-formats.md and skills/rulesync/file-formats.md (remove extra ``````)
  2. Optional: Add edge case tests for invalid frontmatter

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(goose): Add skills support for Goose (.goose/skills/)

2 participants