Update xml participant to support rpc#141
Draft
Barry-Xu-2018 wants to merge 7 commits intoeProsima:0.3.0from
Draft
Update xml participant to support rpc#141Barry-Xu-2018 wants to merge 7 commits intoeProsima:0.3.0from
Barry-Xu-2018 wants to merge 7 commits intoeProsima:0.3.0from
Conversation
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Contributor
|
@MiguelCompany could you include appropriate members from eProsima for further discussion on this? |
Contributor
| continue; | ||
| } | ||
|
|
||
| RpcPayloadData& rpc_data = dynamic_cast<RpcPayloadData&>(*data); |
Contributor
There was a problem hiding this comment.
this is just a bug fix in mainline, i created another PR for this #142.
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
fujitatomoya
force-pushed
the
develop/xml_participant_support_RPC
branch
from
5733e4b to
6d7bbbb
Compare
Contributor
|
@Barry-Xu-2018 @fujitatomoya thank you for your contribution guys. Unfortunately at this moment we don't have the resources to move forward with this, but we will try to review it whenever possible. |
Contributor
|
No rush, please have a look when you have time! thanks 👍 |
This is a workaround for the issue. For a discussion on this topic, please refer to: eProsima#146 (comment) Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Author
|
I ported this PR to main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #140