Skip to content

Fast DDS Spy tool tests#21

Merged
jparisu merged 63 commits intomainfrom
test/tool
Jun 22, 2023
Merged

Fast DDS Spy tool tests#21
jparisu merged 63 commits intomainfrom
test/tool

Conversation

@irenebm
Copy link
Copy Markdown
Contributor

@irenebm irenebm commented Mar 27, 2023 •
edited
Loading

No description provided.

@irenebm irenebm temporarily deployed to codecov March 27, 2023 06:41 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 27, 2023 06:45 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 27, 2023 07:11 — with GitHub Actions Inactive
jparisu
jparisu suggested changes Mar 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jparisu jparisu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests must be rechecked, as they do not apport value as they are.
The main problem is that a test from another application that checks closure has been copied.
These tests are meant to test the application, while the one copied only checks closure (and it closes differently than this one).
Tests must be redesign.

Comment thread fastddsspy_tool/test/application/CMakeLists.txt Outdated
Comment thread fastddsspy_tool/test/application/CMakeLists.txt Outdated
Comment thread fastddsspy_tool/test/application/CMakeLists.txt Outdated
Comment thread fastddsspy_tool/test/application/tests.py Outdated
@irenebm irenebm temporarily deployed to codecov March 28, 2023 06:01 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 28, 2023 06:22 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 28, 2023 06:48 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 28, 2023 06:56 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 28, 2023 07:25 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 28, 2023 14:25 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 29, 2023 10:22 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 29, 2023 11:53 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 29, 2023 13:55 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 30, 2023 05:55 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 30, 2023 08:02 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 30, 2023 09:23 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 30, 2023 15:18 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 31, 2023 09:50 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 31, 2023 11:45 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov April 4, 2023 15:12 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov April 5, 2023 06:11 — with GitHub Actions Inactive
@irenebm irenebm mentioned this pull request Apr 11, 2023
Closed
irenebm added 24 commits June 21, 2023 09:21
@irenebm
Some fixes
b1e12ae 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Without return code
88b5705 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Update
865ff71 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Some fixes
5186bd8 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Time changes
59ff746 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Fix time, uncrustify and python linter
642dd9d 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Uncrustify and more timeout
ef5ecf1 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
add lease_duration
2b3c966 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
More timeout
5a9d116 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
add stop when fail
97e5476 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Add Release path
db3e8fe 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Fix stop tool when wrong output and sys.exit(0)
e6188a0 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Fix exit and give time to stop
a7165e3 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Less timeout
ff1d9af 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
timeout=15
7d927ea 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Fix python linter
208ffb9 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Give more time to stop
1b237bf 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
change kill publisher
0cf9a3d 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
kill publisher
938f640 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Apply changes
f4239f7 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Testing
a8ebe77 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Add docu code
f50431f 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Debug
c05f028 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Apply changes
bc1849e 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
jparisu
jparisu reviewed Jun 21, 2023
View reviewed changes
Comment thread fastddsspy_tool/test/application/CMakeLists.txt Outdated
Comment thread fastddsspy_tool/test/application/CMakeLists.txt Outdated
Comment thread fastddsspy_tool/test/application/test.py Outdated
Comment thread fastddsspy_tool/test/application/test_class.py
Comment thread fastddsspy_tool/test/application/test_class.py Outdated
Comment thread fastddsspy_tool/test/application/test_class.py Outdated
Comment thread fastddsspy_tool/test/application/test_class.py
Comment thread fastddsspy_tool/test/application/test_class.py
Comment thread fastddsspy_tool/test/application/one_shot__config.py
jparisu
jparisu suggested changes Jun 21, 2023
View reviewed changes
Comment thread fastddsspy_tool/test/application/test.py
jparisu
jparisu suggested changes Jun 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about the test cases:

Summarizing: tests are fine, but the range of scenarios that are proven is very thick. I would add comments in README regarding the those scenarios that would be fine to test in the future (any datareader, more than one entity of some kind, etc.)

Comment thread fastddsspy_tool/test/application/test_cases/one_shot__config_fail_empty_arg.py
Comment thread fastddsspy_tool/test/application/test_cases/one_shot__help.py
Comment thread fastddsspy_tool/test/application/test_cases/one_shot__version.py
Comment thread fastddsspy_tool/test/application/test_cases/one_shot_datareader_verbose_dds.py
Comment thread fastddsspy_tool/test/application/test_cases/one_shot_topics_name_dds.py Outdated
irenebm added 2 commits June 21, 2023 16:08
@irenebm
Apply changes
d5fc618 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm
Apply changes
701426c 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
jparisu
jparisu approved these changes Jun 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jparisu jparisu jparisu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@irenebm @jparisu