Skip to content

Fix Python server implementation#53

Open
BSchilperoort wants to merge 2 commits into
mainfrom
fix-py-server-body
Open

Fix Python server implementation#53
BSchilperoort wants to merge 2 commits into
mainfrom
fix-py-server-body

Conversation

@BSchilperoort
Copy link
Copy Markdown
Member

@BSchilperoort BSchilperoort commented Apr 21, 2026

During testing two issues arose;

  • connexions passes a single argument as "body", so this broke some of the setters.
  • get_value_at_indices had arguments turned around for the model call

Using the BMI Controller and the BMI Heat example I was able to validate these methods now work correctly.

Copy link
Copy Markdown
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

Tested it with heat and Swagger UI
uv pip install git+https://github.com/csdms/bmi-example-python
uv pip install connexion[swagger-ui]
# Set swagger_ui=True in python/src/remotebmi/server/__init__.py
wget https://github.com/csdms/bmi-example-python/raw/refs/heads/master/examples/heat.yaml
BMI_MODULE=heat BMI_CLASS=BmiHeat uv run run-bmi-server

Seems R has args in get_value_at_indices swapped in spec. and model wrapped by server is not passing dest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants