Skip to content

Conversation

@henrikjacobsenfys
Copy link
Member

First draft of sample and resolution model. If I could get some feedback on the general outline that'd be great. There's still a lot of polishing and testing to be done, but the general idea is there. Try out the sample_model.ipynb notebook in examples :)

@henrikjacobsenfys henrikjacobsenfys added [scope] enhancement Adds/improves features (major.MINOR.patch) [priority] medium Normal/default priority labels Jan 13, 2026
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 1.18577% with 250 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.22%. Comparing base (2ef5011) to head (67296fa).

Files with missing lines Patch % Lines
src/easydynamics/sample_model/sample_model.py 0.00% 87 Missing ⚠️
src/easydynamics/sample_model/sample_model_base.py 0.00% 83 Missing ⚠️
src/easydynamics/sample_model/instrument_model.py 0.00% 53 Missing ⚠️
src/easydynamics/sample_model/resolution_model.py 0.00% 16 Missing ⚠️
src/easydynamics/sample_model/background_model.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #69       +/-   ##
============================================
- Coverage    97.83%   74.22%   -23.61%     
============================================
  Files           16       21        +5     
  Lines          786     1036      +250     
============================================
  Hits           769      769               
- Misses          17      267      +250     
Flag Coverage Δ
unittests 74.22% <1.18%> (-23.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] medium Normal/default priority [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants