Fix PPC64 JIT conditional branch offset overflow for large QVM files#387
Closed
Fix PPC64 JIT conditional branch offset overflow for large QVM files#387
Conversation
emit_branchConditionalShort() used PPC_BC which only supports 16-bit signed offsets (±32KB). Large QVM files like cgame.qvm have branch targets exceeding this limit, causing 'offset is too large' errors. Replace with long-form pattern: inverted conditional branch (+8) to skip over an unconditional branch (26-bit offset, ±128MB range). This ensures consistent code size across compilation passes and works for any QVM size on both ppc64le and ppc64.
Owner
|
Could you send me such large qvms? |
Contributor
Author
|
@ec- this issue would impact pretty much all standard map, when I submitted the PPC64 JIT patch then, I missed this issue because I was testing with replays/demos in automated fashion only. |
Owner
|
So this is with stock 1.32b gamecode? |
Owner
|
@runlevel5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.