Open
Conversation
Member
haschek
commented
Mar 3, 2026
haschek
commented
- replace native picker
- provide palette colors
| disabled = (!disableNativePicker && !allowCustomColor) || otherTextFieldProps.disabled; | ||
| }; | ||
| updateConfig(); | ||
| React.useEffect(() => { |
Member
There was a problem hiding this comment.
i'd suggest to memo the computation here. useEffect is for side effects.
| */ | ||
| ColorField.calculateColorHashValue = ( | ||
| text: string, | ||
| options: calculateColorHashValueProps = { |
Member
There was a problem hiding this comment.
same values as the as in the Color'Field props default, define them only once.
| }, [allowCustomColor, includeColorWeight, includePaletteGroup, otherTextFieldProps]); | ||
|
|
||
| React.useEffect(() => { | ||
| setColorValue(defaultValue || value || "#000000"); |
Member
There was a problem hiding this comment.
not sure, why this is neccesary. also: https://react.dev/learn/you-might-not-need-an-effect#resetting-all-state-when-a-prop-changes
| forwardOnChange(e); | ||
| }} | ||
| > | ||
| <Tooltip key={idx} content={color[0].replace(`${eccgui}-color-palette-`, "")}> |
Member
There was a problem hiding this comment.
not sure, why idx is used here, an not on the parent RadioButton
| setColorValue(defaultValue || value || "#000000"); | ||
| }, [defaultValue, value]); | ||
|
|
||
| const forwardOnChange = (forwardedEvent: React.ChangeEvent<HTMLInputElement>) => { |
Member
There was a problem hiding this comment.
minor remark: this could be inlined
| } | ||
|
|
||
| const getEnabledColorsFromPaletteCache = new Map<string, Color[]>(); | ||
| const getEnabledColorPropertiesFromPaletteCache = new Map<string, string[][]>(); |
Member
There was a problem hiding this comment.
string[][] is there perhaps a better type for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.