Forward tree search text to extension backend#7
Open
phongtrinh1234 wants to merge 2 commits intoeclipse-cdt-cloud:mainfrom
Open
Forward tree search text to extension backend#7phongtrinh1234 wants to merge 2 commits intoeclipse-cdt-cloud:mainfrom
phongtrinh1234 wants to merge 2 commits intoeclipse-cdt-cloud:mainfrom
Conversation
Contributor
|
Thanks for your contribution, @phongtrinh1234 . |
Expose search text updates through vscode-messenger so extensions can implement backend search for large trees. Also document the new onDidSearchChanged event in the tree README.
phongtrinh1234
force-pushed
the
tree-backend-search-support
branch
from
58e086e to
7ecbcb0
Compare
jreineckearm
reviewed
Mar 6, 2026
Contributor
jreineckearm
left a comment
jreineckearm
left a comment
There was a problem hiding this comment.
Nice, thanks a lot for these changes. Just one nit from code review.
Not tested yet in combination with eclipse-cdt-cloud/vscode-peripheral-inspector#75 Will approve once I had a chance to do so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes search text updates from the CDTTree search feature
via vscode-messenger.
This is required to support backend search in the Peripheral Inspector
to address performance issues with large SVD files.
Related to:
eclipse-cdt-cloud/vscode-peripheral-inspector#71